public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Herzig <d.herzig@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] api: vmlist: add plugged cpu count to vmlist table
Date: Fri, 17 Jan 2025 17:25:52 +0100	[thread overview]
Message-ID: <ea33f80a-82b2-4c14-92e1-32417ef4c044@proxmox.com> (raw)
In-Reply-To: <36eb1444-2d84-4461-a3b7-d6e2705fee97@proxmox.com>

On 1/17/25 16:27, Thomas Lamprecht wrote:
> Am 17.01.25 um 16:10 schrieb Daniel Kral:
>> What do you think about fixing the problem from the other side: I could
>> do a follow up where it's not possible to actively assign a VM more
>> resources than currently available, since it would not boot anyway? I
>> think there's a negligible amount of users who'd want to configure more
>> resources and only later upgrade to the required primary memory or a
>> heavier CPU (wrt to their core count).
> 
> Such a VM might not boot on it's current node, but it could boot on
> another node with more CPU cores. Often not a big issue, but we avoid
> such restrictions as they often create more friction without providing
> that much help – a UI only hint in case of setting more cores than the
> current node supports might be better here.

Thanks for the insight, that makes sense and I haven't thought about it 
in the cluster context, I'll keep that in mind for future changes!

> 
> Maybe best to just ignore the glitch in the output for now, or indeed
> duplicate the calculation, or look into why vmstatus does it that way
> and see if it could be unclamped there (or a new property is warranted).
> 
> btw. you use the "api" prefix for this patch, but it should be "cli",
> as this is not changing the (REST) API in any way.

Thanks for pointing that out, I'll change that for a v2! I'll also take 
a second closer look why it has been clamped there and if it can be 
unclamped in a separate patch for v2.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      reply	other threads:[~2025-01-17 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10 17:09 Daniel Kral
2025-01-13  9:45 ` Daniel Herzig
2025-01-17 15:10   ` Daniel Kral
2025-01-17 15:27     ` Thomas Lamprecht
2025-01-17 16:25       ` Daniel Kral [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea33f80a-82b2-4c14-92e1-32417ef4c044@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=d.herzig@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal