From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CE29E630D5 for ; Mon, 14 Feb 2022 08:06:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C3A741F769 for ; Mon, 14 Feb 2022 08:06:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2247E1F75B for ; Mon, 14 Feb 2022 08:06:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ED34841992; Mon, 14 Feb 2022 08:06:35 +0100 (CET) Message-ID: Date: Mon, 14 Feb 2022 08:06:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-US To: Harikrishnan R , pve-devel@lists.proxmox.com References: <20220213132759.1268561-1-rharikrishnan95@gmail.com> <20220213132759.1268561-2-rharikrishnan95@gmail.com> From: Thomas Lamprecht In-Reply-To: <20220213132759.1268561-2-rharikrishnan95@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH container 1/1] Setup: add NixOS support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2022 07:06:42 -0000 thanks for your contribution! meta: The commit is missing your Signed-off-by and, FWICT, we don't have yet a signed CLA - if that's the case please check: https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright On 13.02.22 14:27, Harikrishnan R wrote: > Distro detection is done through the presence of a /nix folder. seems a bit arbitrary and we only still do such things in general for legacy reasons, new distros should be able to get the info from the (somewhat) standard /etc/os-release file - or is that not guaranteed for Nix Note that "nix" is a valid word in some languages, e.g., in german so finding such a folder, in another distro is, while unlikely, not completely impossible. > NixOS typically uses a script-based network configuration system > that isn't easy to configure from the outside. LXC templates Can be ok for an initial inclusion, and while networking itself doesn't seems to bad to generate [0], the level of how elaborate that should parse and cooperate with existing Nix statements can naturally complicate that, but adding a fixed output at the top of the file into a comment marked section, like we do already for other distros, should allow to override it by the user internally. [0]: https://nixos.wiki/wiki/Networking > generated for proxmox are instead expected to use systemd-networkd. So, basically this is just like a unmanaged CT but with systemd network setup? Not sure if that adds /that/ much value over unmanaged, or maybe better said, as currently implements this would rather be a "sd-network" ostype. On the other hand, such simple distro types have not /that/ much cost to maintain either, so not intending to block this - albeit some more elaborate implementation would be welcomed :-)