From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D08977275F for ; Tue, 13 Apr 2021 09:08:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C54FE26FE4 for ; Tue, 13 Apr 2021 09:08:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B9A0E26FD5 for ; Tue, 13 Apr 2021 09:08:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 781DA41D87 for ; Tue, 13 Apr 2021 09:08:39 +0200 (CEST) Message-ID: Date: Tue, 13 Apr 2021 09:08:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20210215152647.7328-1-a.lauterer@proxmox.com> <20210215152647.7328-2-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210215152647.7328-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v5 widget-toolkit 1/3] window/edit: add option to disable reset button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 07:08:40 -0000 On 15.02.21 16:26, Aaron Lauterer wrote: > Sometimes the reset button does not make sense and the isCreate option > does not fit as well because with it, the submit button will be enabled > right away instead of waiting for the form to be valid. > > Signed-off-by: Aaron Lauterer > --- > > v1 -> v2 -> v3 -> v4 -> v5: nothing changed > > This helps to reuse the PVE.window.Edit component in a modern viewModel > and controller way instead of building it all by hand the old way with a > large initComponent method. > > A possible candidate for refactoring after this would be the > qemu/HDMove.js component. > > > src/window/Edit.js | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > applied, thanks!