From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BE1619238B for ; Thu, 1 Feb 2024 14:41:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F8621084F for ; Thu, 1 Feb 2024 14:40:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 1 Feb 2024 14:40:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CD87340B84 for ; Thu, 1 Feb 2024 14:40:54 +0100 (CET) Message-ID: Date: Thu, 1 Feb 2024 14:40:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20240130184041.1125674-1-m.carrara@proxmox.com> <20240130184041.1125674-8-m.carrara@proxmox.com> <1706705626.o4yd1a79z3.astroid@yuna.none> From: Max Carrara In-Reply-To: <1706705626.o4yd1a79z3.astroid@yuna.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.437 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied-partially: [PATCH pve-manager 7/8] debian/postinst: fix shellcheck warning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2024 13:41:25 -0000 On 1/31/24 14:16, Fabian Grünbichler wrote: > On January 30, 2024 7:40 pm, Max Carrara wrote: >> SC3043 (warning): In POSIX sh, 'local' is undefined. > > while I get why you sent this here, it's not related at all to this > series, please send such changes on their own and reference them if > needed in the future. > > in this case it's actually not needed at all: > https://www.debian.org/doc/debian-policy/ch-files.html#s-scripts > > local is pretty much impemented by every shell under the sun, it's just > that POSIX couldn't agree how to handle them when `unset` is called, so > they are not part of POSIX. Thanks, that's helpful! Will then just drop this patch in v2 and tell shellcheck to shut up. > >> Signed-off-by: Max Carrara >> --- >> debian/postinst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/debian/postinst b/debian/postinst >> index 6138ef6d..00d5f2cc 100755 >> --- a/debian/postinst >> +++ b/debian/postinst >> @@ -9,7 +9,7 @@ set -e >> # installed and configured. >> >> set_lvm_conf() { >> - local FORCE="$1" >> + FORCE="$1" >> LVM_CONF_MARKER="# added by pve-manager to avoid scanning" >> >> # keep user changes afterwards provided marker is still there.. >> -- >> 2.39.2 >> >> >> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >> >> >> > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >