From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 33C43B98F for ; Thu, 7 Apr 2022 15:30:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 29BE25642 for ; Thu, 7 Apr 2022 15:30:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AFE485632 for ; Thu, 7 Apr 2022 15:30:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 856DE46D2B for ; Thu, 7 Apr 2022 15:30:11 +0200 (CEST) Message-ID: Date: Thu, 7 Apr 2022 15:30:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20220407121544.159514-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220407121544.159514-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH manager] ui: lxc: resources: consider rootfs as a disk again X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 13:30:12 -0000 On 07.04.22 14:15, Fabian Ebner wrote: > Commit fa7980c2 ("ui: lxc resources: switch to vector based font > awesome icons") seems like an innocent change, but it broke the > (very brittle) logic here by removing the tdCls for rootfs. holy moly, didn't really expect that the gui is using css classes as a state storage, yuck. > > Signed-off-by: Fabian Ebner > --- > www/manager6/lxc/Resources.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks for catching!