From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CA16968A2F for ; Fri, 10 Sep 2021 10:32:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE74911584 for ; Fri, 10 Sep 2021 10:32:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0CC6511579 for ; Fri, 10 Sep 2021 10:32:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CEBA144654 for ; Fri, 10 Sep 2021 10:32:15 +0200 (CEST) To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20210910074820.1477562-1-f.gruenbichler@proxmox.com> From: Fabian Ebner Message-ID: Date: Fri, 10 Sep 2021 10:32:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910074820.1477562-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.354 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.975 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 08:32:16 -0000 The same issues are present for the corresponding API call in pve-container ;) Both patches Reviewed-by: Fabian Ebner Am 10.09.21 um 09:48 schrieb Fabian Grünbichler: > as reported on the forum, this is currently missing, making status > queries via the API impossible: > > https://forum.proxmox.com/threads/create-vm-via-api-interface.95942/#post-416084 > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index ef0d877..0a23525 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -4336,7 +4336,10 @@ __PACKAGE__->register_method({ > > }, > }, > - returns => { type => 'null'}, > + returns => { > + type => 'string', > + description => "the task ID.", > + }, > code => sub { > my ($param) = @_; > > @@ -4375,8 +4378,7 @@ __PACKAGE__->register_method({ > return $rpcenv->fork_worker('qmtemplate', $vmid, $authuser, $realcmd); > }; > > - PVE::QemuConfig->lock_config($vmid, $updatefn); > - return; > + return PVE::QemuConfig->lock_config($vmid, $updatefn); > }}); > > __PACKAGE__->register_method({ >