From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 256486BF3F for ; Thu, 28 Jan 2021 14:19:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 194782DE38 for ; Thu, 28 Jan 2021 14:19:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AF2F82DE28 for ; Thu, 28 Jan 2021 14:19:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7AD4E46140 for ; Thu, 28 Jan 2021 14:19:45 +0100 (CET) To: Proxmox VE development discussion , Dylan Whyte References: <20210128110108.28497-1-d.whyte@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Thu, 28 Jan 2021 14:19:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Thunderbird/85.0 MIME-Version: 1.0 In-Reply-To: <20210128110108.28497-1-d.whyte@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.064 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pveum.pm] Subject: Re: [pve-devel] [PATCH pve-access-control] resource pools: add resource pool cli commands X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 13:19:49 -0000 On 28.01.21 12:01, Dylan Whyte wrote: > Add commands for creating, modifying, listing, and deleting resource > pools. > > Signed-off-by: Dylan Whyte > --- > PVE/CLI/pveum.pm | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/PVE/CLI/pveum.pm b/PVE/CLI/pveum.pm > index c98ddde..0540b85 100755 > --- a/PVE/CLI/pveum.pm > +++ b/PVE/CLI/pveum.pm > @@ -10,6 +10,7 @@ use PVE::API2::Group; > use PVE::API2::Role; > use PVE::API2::ACL; > use PVE::API2::AccessControl; > +use PVE::API2::Pool; > use PVE::API2::Domains; > use PVE::CLIFormatter; > use PVE::CLIHandler; > @@ -145,7 +146,12 @@ our $cmddef = { > delete => [ 'PVE::API2::ACL', 'update_acl', ['path'], { delete => 1 }], > list => [ 'PVE::API2::ACL', 'read_acl', [], {}, $print_api_result, $PVE::RESTHandler::standard_output_options], > }, > - > + pool => { > + add => [ 'PVE::API2::Pool', 'create_pool', ['poolid'] ], > + modify => [ 'PVE::API2::Pool', 'update_pool', ['poolid'] ], > + delete => [ 'PVE::API2::Pool', 'delete_pool', ['poolid'] ], > + list => [ 'PVE::API2::Pool', 'index', [], {}, $print_api_result, $PVE::RESTHandler::standard_output_options], > + }, > realm => { > add => [ 'PVE::API2::Domains', 'create', ['realm'] ], > modify => [ 'PVE::API2::Domains', 'update', ['realm'] ], > @@ -176,6 +182,10 @@ our $cmddef = { > > aclmod => { alias => 'acl modify' }, > acldel => { alias => 'acl delete' }, > + > + pooladd => { alias => 'pool add' }, > + poolmod => { alias => 'pool modify' }, > + pooldel => { alias => 'pool delete' }, Those aliases are only for backward compatibility for the old version, from when we introduced sub-commands. New commands do not need them as we prefer sub-commands. > }; > > 1; >