From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 55F281FF162
for <inbox@lore.proxmox.com>; Mon, 7 Apr 2025 10:33:19 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id BB076389B7;
Mon, 7 Apr 2025 10:33:15 +0200 (CEST)
Message-ID: <e8978d37-a72e-4d58-87f3-b58457b42d64@proxmox.com>
Date: Mon, 7 Apr 2025 10:32:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20240614092134.18729-1-f.ebner@proxmox.com>
Content-Language: en-US
In-Reply-To: <20240614092134.18729-1-f.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.037 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server] qmeventd: go back to extracting
vmid from commandline instead of cgroup file
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Am 14.06.24 um 11:21 schrieb Fiona Ebner:
> In spirit, this is a revert of 502870a0 ("qmeventd: extract vmid from
> cgroup file instead of cmdline"), but instead of relying on the custom
> 'id' commandline option that's added by a Proxmox VE patch to QEMU,
> rely on the standard 'pidfile' option to extract the VM ID.
>
> As reported in the community forum [0], at least during stop mode
> backup, it seems to be possible to end up with the VM process having
>> 0::/system.slice/pvescheduler.service
> as its single cgroup entry. It's not clear what exactly happens and
> there was no success to reproduce the issue. Might be a rare bug in
> systemd or in pve-common's enter_systemd_scope() code.
>
> This was not the first time relying on the cgroup entry caused issues,
> see d0b58753 ("qmeventd: improve getting VMID from PID in presence of
> legacy cgroup entries").
>
> To avoid such edge cases and issues in the future, go back to
> extracting the VM ID from the process's commandline.
>
> It's enough to care about the first occurrence of the 'pidfile'
> option, because that's the one added by Proxmox VE, so the 'continue's
> in the loop turn into 'break's. Even though a later option would
> override the first for QEMU itself to use, that's not supported
> anyways and the important part is the VM ID which is present in the
> first.
>
> [0]: https://forum.proxmox.com/threads/147409/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Ping. After it was quiet for ~10 months, there were 2 new reports about
this yesterday:
https://forum.proxmox.com/threads/147409/post-761580
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel