From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 96ECA1FF15C
	for <inbox@lore.proxmox.com>; Wed, 26 Mar 2025 14:14:26 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id D71E437861;
	Wed, 26 Mar 2025 14:14:19 +0100 (CET)
Message-ID: <e818895d-da8e-42fd-a89d-a5972aba2c73@proxmox.com>
Date: Wed, 26 Mar 2025 14:13:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20250205100850.3-1-a.zeidler@proxmox.com>
 <b5662161-9f81-4a67-b3de-a1246f1b272c@proxmox.com>
 <D8Q4F466MP1B.54FKSGGJF7WL@proxmox.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <D8Q4F466MP1B.54FKSGGJF7WL@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.433 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible
 spam tricks
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: Re: [pve-devel] applied: [PATCH docs v2 1/6] ceph: add anchors for
 use in troubleshooting section
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>



On  2025-03-26  11:20, Max Carrara wrote:
> On Mon Mar 24, 2025 at 5:42 PM CET, Aaron Lauterer wrote:
>>
>>
>> On  2025-02-05  11:08, Alexander Zeidler wrote:
>>> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
>>> ---
>>> v2:
>>> * add two missing anchors to be usable via xref
>>>
>>>    pve-disk-health-monitoring.adoc | 1 +
>>>    pveceph.adoc                    | 8 ++++++++
>>>    pvecm.adoc                      | 1 +
>>>    3 files changed, 10 insertions(+)
>>>
>>>
>> thanks for the work to extend the docs!
>>
>> applied with some changes and follow-ups:
>>
>> * we do not want to break the anchor to the ceph recommendations. This
>> anchor is in use to redirect customers and users to ceph requirements.
>> Yes it is ugly, but we cannot change it so we keep it.
>> * I do not think that inline CLI commands are a good idea as they are
>> make the paragraph messy and harder to read and are hard to copy&paste.
>> Therefore, I rephrased those parts to have them in their own code blocks.
>> * rephrased the Destroy OSD section, mainly to also place the CLI
>> commands into code blocks and a few other things you can see in the
>> follow up commit.
> 
> Aw, without my R-b and T-b tags, unfortunately :(
> 
> Is there any reason in particular that they weren't added?

Me being blind. Sorry for that.

> 
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel