From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7C9CD73584 for <pve-devel@lists.proxmox.com>; Thu, 15 Apr 2021 14:21:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 79F1819B6C for <pve-devel@lists.proxmox.com>; Thu, 15 Apr 2021 14:21:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 08E0519B62 for <pve-devel@lists.proxmox.com>; Thu, 15 Apr 2021 14:21:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C765A45AE1 for <pve-devel@lists.proxmox.com>; Thu, 15 Apr 2021 14:21:25 +0200 (CEST) Message-ID: <e805bf78-765c-b6bf-e0f7-3ac0f793bc3c@proxmox.com> Date: Thu, 15 Apr 2021 14:21:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com>, Aaron Lauterer <a.lauterer@proxmox.com> References: <20210402101923.13050-1-a.lauterer@proxmox.com> <20210402101923.13050-2-a.lauterer@proxmox.com> <f9a58dbd-9b10-52de-30a3-0be95cf020c3@proxmox.com> <b557a2f6-cb5f-86c4-8ecf-f3cd2049fe8a@proxmox.com> <3a122331-1f39-5e52-bcff-8ed28f763a2c@proxmox.com> <9db5fb6f-4fa5-ec01-9662-72c27fa42304@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <9db5fb6f-4fa5-ec01-9662-72c27fa42304@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v6 storage 1/1] add disk reassign feature X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 15 Apr 2021 12:21:26 -0000 On 15.04.21 14:09, Fabian Ebner wrote: >> IMHO it would be nice though to change the structure of the storage pl= ugins a bit. E.g. instead of assuming dir/file storages for Plugin.pm, ha= ving a basic abstraction specifically for any directory/file based storag= e which handles all the common tasks and further down the hierarchy the s= pecific implementations regarding mounting and such. But that would mean = a hard break of the current approach, especially for 3rd party=C2=A0plugi= ns. >> >=20 > I was under the impression that this is one of the functions of APIVERS= ION. External plugins can look at the changes since the last version they=20 supported, decide if they're happy with the default implementation=C2=A0a= nd=C2=A0implement=C2=A0their=C2=A0own=C2=A0otherwise. >=20 > @Thomas:=C2=A0Is=C2=A0this=C2=A0wrong? No that's right.