From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C1D7D94C78 for ; Fri, 23 Feb 2024 11:51:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D04216C01 for ; Fri, 23 Feb 2024 11:50:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Feb 2024 11:50:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C701A44EF8 for ; Fri, 23 Feb 2024 11:50:46 +0100 (CET) Message-ID: Date: Fri, 23 Feb 2024 11:50:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Fiona Ebner , Proxmox VE development discussion References: <20230901090553.17817-1-f.schauer@proxmox.com> <43c10b65-9ba5-4e64-87d5-1ec7dd961b9b@proxmox.com> From: Filip Schauer In-Reply-To: <43c10b65-9ba5-4e64-87d5-1ec7dd961b9b@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.354 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH container] fix #4846: Avoid the outdated noacl mount option on ext4 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2024 10:51:17 -0000 A v2 of this patch is available: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061932.html On 16/02/2024 14:59, Fiona Ebner wrote: > Am 01.09.23 um 11:05 schrieb Filip Schauer: >> Do not use the 'noacl' mount option when mounting a container disk with >> an ext4 file system. The option was removed from the kernel in commit >> 2d544ec923db >> >> Signed-off-by: Filip Schauer >> --- >> src/PVE/LXC.pm | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm >> index 1e9af0f..3ebce37 100644 >> --- a/src/PVE/LXC.pm >> +++ b/src/PVE/LXC.pm >> @@ -1764,9 +1764,6 @@ sub __mountpoint_mount { >> } >> >> my $acl = $mountpoint->{acl}; >> - if (defined($acl)) { >> - push @$optlist, ($acl ? 'acl' : 'noacl'); >> - } >> >> my $optstring = join(',', @$optlist); > This is the last time optlist is read from, so the below hunk won't have > any effect? > >> my $readonly = $mountpoint->{ro}; >> @@ -1787,6 +1784,13 @@ sub __mountpoint_mount { >> >> $format = 'iso' if $vtype eq 'iso'; # allow to handle iso files >> >> + # Avoid the outdated 'noacl' mount option on ext4 file systems >> + if ($scfg->{type} ne 'zfspool') { > While we only format Proxmox VE managed volumes with ext4, this mount > code is potentially called for other FS types too. For example, I can > manually format a mount point with BTRFS - where noacl is apparently > still a valid option. While a niche use case, and potentially something > we could risk breaking until somebody complains, maybe we can detect FS > type and filter based on that? > >> + push @$optlist, 'acl' if $acl; >> + } elsif (defined($acl)) { >> + push @$optlist, ($acl ? 'acl' : 'noacl'); >> + } >> + >> if ($format eq 'subvol') { >> if ($mount_path) { >> my (undef, $name) = PVE::Storage::parse_volname($storage_cfg, $volid);