From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id C76808B41
 for <pve-devel@lists.proxmox.com>; Thu, 22 Jun 2023 15:50:30 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id A7B2527348
 for <pve-devel@lists.proxmox.com>; Thu, 22 Jun 2023 15:50:30 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Thu, 22 Jun 2023 15:50:30 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE8C942B49;
 Thu, 22 Jun 2023 15:50:29 +0200 (CEST)
Message-ID: <e79ab8b5-69ce-08f4-bbcd-998ad9a06353@proxmox.com>
Date: Thu, 22 Jun 2023 15:50:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Alexandre Derumier <aderumier@odiso.com>
References: <20230622105437.2130941-1-aderumier@odiso.com>
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <20230622105437.2130941-1-aderumier@odiso.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.089 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.093 Looks like a legit reply (A)
 POISEN_SPAM_PILL_4        0.1 random spam to be learned in bayes
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH pve-manager] ui: ceph status: add pg warning
 state
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 22 Jun 2023 13:50:30 -0000

The light blue used in .normal is a tad too light IMHO for the cake diagram. It 
is the light blue used in the light theme, for example to indicate the active 
element in the tree view.

What about using a stronger blue? I switched to .info-blue and it was definitely 
nicer. It might even be a good idea to specify a dedicated .working color CSS 
class in the ext6-pmx.css (widget-toolkit).

Another thing I noticed, in the commit message you are talking about PGs in 
critical state. But in the code we use "Error". I would suggest that we rename 
that to Critical to align it more with the nomenclature.

e.g.:

diff --git a/www/manager6/ceph/StatusDetail.js b/www/manager6/ceph/StatusDetail.js
index e1bf425a..11dfb0d2 100644
--- a/www/manager6/ceph/StatusDetail.js
+++ b/www/manager6/ceph/StatusDetail.js
@@ -169,7 +169,7 @@ Ext.define('PVE.ceph.StatusDetail', {
         degraded: 3,
         undersized: 3,

-       // error
+       // critical
         backfill_toofull: 4,
         backfill_unfound: 4,
         down: 4,
@@ -201,7 +201,7 @@ Ext.define('PVE.ceph.StatusDetail', {
             cls: 'warning',
         },
         {
-           text: gettext('Error'),
+           text: gettext('Critical'),
             cls: 'critical',
         },
      ],

On 6/22/23 12:54, Alexandre Derumier wrote:
> Like ceph mgr dashboard, we need a warning state.
> 
> - set degraded && undersized as warning instead criticial
> 
> - add "normal" (light blue) color for working state
> 
> - use warning (orange) color for warning state
> 
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>   www/manager6/ceph/StatusDetail.js | 29 ++++++++++++++++++-----------
>   1 file changed, 18 insertions(+), 11 deletions(-)
> 
> diff --git a/www/manager6/ceph/StatusDetail.js b/www/manager6/ceph/StatusDetail.js
> index d6c0763b..e1bf425a 100644
> --- a/www/manager6/ceph/StatusDetail.js
> +++ b/www/manager6/ceph/StatusDetail.js
> @@ -94,6 +94,7 @@ Ext.define('PVE.ceph.StatusDetail', {
>   	colors: [
>   	    '#CFCFCF',
>   	    '#21BF4B',
> +	    '#C2DDF2',
>   	    '#FFCC00',
>   	    '#FF6C59',
>   	],
> @@ -152,7 +153,6 @@ Ext.define('PVE.ceph.StatusDetail', {
>   	backfilling: 2,
>   	creating: 2,
>   	deep: 2,
> -	degraded: 2,
>   	forced_backfill: 2,
>   	forced_recovery: 2,
>   	peered: 2,
> @@ -165,17 +165,20 @@ Ext.define('PVE.ceph.StatusDetail', {
>   	snaptrim: 2,
>   	snaptrim_wait: 2,
>   
> -	// error
> -	backfill_toofull: 3,
> -	backfill_unfound: 3,
> -	down: 3,
> -	incomplete: 3,
> -	inconsistent: 3,
> -	recovery_toofull: 3,
> -	recovery_unfound: 3,
> -	snaptrim_error: 3,
> -	stale: 3,
> +	//warning
> +	degraded: 3,
>   	undersized: 3,
> +
> +	// error
> +	backfill_toofull: 4,
> +	backfill_unfound: 4,
> +	down: 4,
> +	incomplete: 4,
> +	inconsistent: 4,
> +	recovery_toofull: 4,
> +	recovery_unfound: 4,
> +	snaptrim_error: 4,
> +	stale: 4,
>       },
>   
>       statecategories: [
> @@ -191,6 +194,10 @@ Ext.define('PVE.ceph.StatusDetail', {
>   	},
>   	{
>   	    text: gettext('Working'),
> +	    cls: 'normal',
> +	},
> +	{
> +	    text: gettext('Warning'),
>   	    cls: 'warning',
>   	},
>   	{