From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 9CFBF1FF0A7 for ; Mon, 17 Aug 2026 10:19:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DF7CB238F3; Mon, 17 Aug 2026 10:19:24 +0200 (CEST) Message-ID: Date: Mon, 17 Aug 2026 10:19:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 qemu-server] cloud-init: query volume size via vdisk_list() to fix regression with qcow2 on LVM From: Fiona Ebner To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260812111316.85049-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1786954739901 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.241 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RDNS_NONE 1.274 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OW6HC2DQCEQEJQK2JZOIYDUXVDCRIV4L X-Message-ID-Hash: OW6HC2DQCEQEJQK2JZOIYDUXVDCRIV4L X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 17.08.26 um 10:11 AM schrieb Fiona Ebner: > Am 17.08.26 um 8:59 AM schrieb Dominik Csapak: >> >> a third thing i noticed is that vdisk_list actives the storage, which >> volume_size_info does not (AFAICS). This is probably correct >> anyway but worth noting in the commit message IMO > > I can mention it. And it actually fixes another bug, because the storage is not actually activated anywhere before (for a VM with just the cloudinit disk on the NFS storage): [I] root@pve9a1 ~# qm stop 100; umount /mnt/pve/nfs; and qm start 100 failed to stat '/mnt/pve/nfs/images/100/vm-100-cloudinit.raw' disk image '/mnt/pve/nfs/images/100/vm-100-cloudinit.raw' already exists