From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 85D60BA036 for ; Mon, 18 Mar 2024 16:50:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 662501403D for ; Mon, 18 Mar 2024 16:50:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 18 Mar 2024 16:50:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2055F4660E for ; Mon, 18 Mar 2024 16:50:31 +0100 (CET) Message-ID: Date: Mon, 18 Mar 2024 16:50:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Dominik Csapak References: <20240318134454.2908174-1-d.csapak@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20240318134454.2908174-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [RFC PATCH widget-toolkit] utils: API2Request: defer masking after layout X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2024 15:50:32 -0000 On 18/03/2024 14:44, Dominik Csapak wrote: > since some time (not sure when exactly), the 'load()' method of the edit > window did not correctly mask the window anymore > > the reason seems to be that the API2Request tries to mask the component > before it's rendered, and that did never work correctly judging from the > existing comment. > > Instead of simply calling `setLoading`, test if the component is > rendered, and if not, mask it after it has finished it's layout. > > Since we cannot guarantee that the 'afterlayout' event is triggered > before the api call response handler, add a unique id marker to the > waitMsgTarget that is delted when the loading is done, and only trigger s/delted/deleted/ And why do we need setting a unique ID here and not just a flag? Can a second load be triggered before the first one finished? > the masking if this marker is still there. (thankfully javascript is > single threaded so this should not end up being a data race) Note that async could cause data races also in single-threaded code, but as we do not use that here and no yield point exist that doesn't matter here – just mentioning it because the statement would suggest that one could not have code that is susceptible to such a race at all in JavaScript, which is not true. > > Signed-off-by: Dominik Csapak > --- > sending as RFC because i'm unsure if we accidentally broke the masking > somewhere along the way. AFAICS from the current code, this never could have > worked properly? anyway, i'll be looking into that sometimes soon, and > this patch should be correct anyway... it surely did sometimes in the past, maybe ExtJS 7?