From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BFF0A76122 for ; Thu, 22 Apr 2021 20:41:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B616B20AA3 for ; Thu, 22 Apr 2021 20:41:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A3AD620A94 for ; Thu, 22 Apr 2021 20:41:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 70F8346271 for ; Thu, 22 Apr 2021 20:41:13 +0200 (CEST) Message-ID: Date: Thu, 22 Apr 2021 20:41:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210419110048.20791-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210419110048.20791-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH widget-toolkit/pve-manager] move some code to widget-toolkit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 18:41:44 -0000 On 19.04.21 13:00, Dominik Csapak wrote: > manager needs a depends on a bumped widget-toolkit ofc > > proxmox-widget-toolkit: > > Dominik Csapak (4): > Utils: add several render functions from PVE > bring over some icons from PVE > Utils: refactor updateColumns from pve-manager > panel: add StatusView from PVE > > pve-manger: > > Dominik Csapak (4): > ui: Utils: use render functions from widget-toolkit > ui: use some icons from widget-toolkit > ui: Utils: use updateColumns from widget-toolkit > ui: panel/StatusView: use from widget-toolkit instead > applied series, besides one issue in the status panel (replied inline) it was all OK, FWICT, thanks! Process wise it would be nicer to include the pbs one here too, or at least the widget-toolkit in the pbs-series, it's a bit hard to follow the correlation else...