From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 526DA1FF15C
for <inbox@lore.proxmox.com>; Wed, 19 Feb 2025 16:46:05 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 8C24F2E731;
Wed, 19 Feb 2025 16:45:58 +0100 (CET)
Message-ID: <e5a4134e-7213-40e5-b3f3-2af0ff16416e@proxmox.com>
Date: Wed, 19 Feb 2025 16:45:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
References: <20250211160825.254167-1-d.kral@proxmox.com>
<20250211160825.254167-7-d.kral@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20250211160825.254167-7-d.kral@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.045 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server v2 01/15] test: cfg2cmd: expect
error for invalid volume's storage content type
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Am 11.02.25 um 17:08 schrieb Daniel Kral:
> Tests whether when running `config_to_command` it will correctly fail
> with an error message that a volume cannot be used if the underlying
> storage does not support its content type.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> changes since v1:
> - no changes except removing unrelated diff
>
> test/cfg2cmd/unsupported-storage-content-type.conf | 3 +++
> test/run_config2command_tests.pl | 4 ++++
> 2 files changed, 7 insertions(+)
> create mode 100644 test/cfg2cmd/unsupported-storage-content-type.conf
>
> diff --git a/test/cfg2cmd/unsupported-storage-content-type.conf b/test/cfg2cmd/unsupported-storage-content-type.conf
> new file mode 100644
> index 00000000..e33165a8
> --- /dev/null
> +++ b/test/cfg2cmd/unsupported-storage-content-type.conf
> @@ -0,0 +1,3 @@
> +# TEST: Unsupported storage content type in a volume disk
> +# EXPECT_ERROR: storage 'noimages' does not support content-type 'images'
> +scsi0: noimages:8006/vm-8006-disk-0.raw,iothread=1,size=32G
> diff --git a/test/run_config2command_tests.pl b/test/run_config2command_tests.pl
> index 2feebd4a..440682d4 100755
> --- a/test/run_config2command_tests.pl
> +++ b/test/run_config2command_tests.pl
> @@ -31,6 +31,10 @@ my $base_env = {
> type => 'dir',
> shared => 0,
> },
> + noimages => {
> + path => '/var/lib/vz',
> + type => 'dir',
> + },
I'd add some other content type in this hash. Because we have default
content types, this is not a hash that could be reached by parsing a
storage configuration. Just to avoid any potential (future) breakage
with not having a 'content' key at all.
> 'btrfs-store' => {
> content => {
> images => 1,
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel