From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 800551FF398 for ; Wed, 19 Jun 2024 10:28:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D276237BB7; Wed, 19 Jun 2024 10:28:51 +0200 (CEST) Message-ID: Date: Wed, 19 Jun 2024 10:28:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion References: <20240619063724.200453-1-d.csapak@proxmox.com> <58242816-e1b8-4d53-86d3-f07f250606fe@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <58242816-e1b8-4d53-86d3-f07f250606fe@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH qemu-server] fix #5543: pci: don't use pci devices when starting templates X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 6/19/24 10:17, Fiona Ebner wrote: > Am 19.06.24 um 10:14 schrieb Fiona Ebner: >> I'd be in favor of fixing this together with >> https://bugzilla.proxmox.com/show_bug.cgi?id=3352 >> and use a minimal QEMU commandline that only attaches the block devices >> and nothing else. I guess the addition for the PCI cleanup is still >> needed, but getting the minimal commandline is probably best done as a >> new helper. What do you think? >> > > Another way would be to reduce the config we pass to config_to_command > to only the block devices and 1 CPU, etc.. Maybe that's more > straight-forward than a new helper. yeah, some combined fix for that would be good, did not have that bug on my radar. I agree that 'minifying' the config is probably the way to go here, but as you said, the cleanup should also be touched so it does not throw warnings for not available devices etc. I think we could have a set of keys as a whitelist to copy, and leave all others default, i think for starters we should whitelist: * all disk configs (excl. cdroms) * the kvm setting * anything else ? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel