From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B2BDCC576 for ; Fri, 7 Jul 2023 14:59:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9275E29A11 for ; Fri, 7 Jul 2023 14:59:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Jul 2023 14:59:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE954409FF for ; Fri, 7 Jul 2023 14:59:05 +0200 (CEST) Message-ID: Date: Fri, 7 Jul 2023 14:59:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox VE development discussion , Alexander Zeidler References: <20230615141445.188274-1-a.zeidler@proxmox.com> <20230615141445.188274-4-a.zeidler@proxmox.com> From: Fiona Ebner In-Reply-To: <20230615141445.188274-4-a.zeidler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.091 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH v2 container 3/4]: add 'pbs-entries-max' parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2023 12:59:36 -0000 Am 15.06.23 um 16:14 schrieb Alexander Zeidler: > configuring pbs-entries-max can avoid failing backups due to a high > amount of files in folders where a folder exclusion is not possible > > Signed-off-by: Alexander Zeidler > --- > Changes from v1: > Reword loginfo message and include new set value > Fix indentation > > > src/PVE/VZDump/LXC.pm | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm > index 5783ffa..a9e0ffb 100644 > --- a/src/PVE/VZDump/LXC.pm > +++ b/src/PVE/VZDump/LXC.pm > @@ -395,6 +395,11 @@ sub archive { > push @$param, '--backup-id', $vmid; > push @$param, '--backup-time', $task->{backup_time}; > > + if ($opts->{"pbs-entries-max"}) { It's part of performance now so this doesn't work. Style nit: you can write if (my $foo = $bar->{"too-long-to-read-and-type-each-time"}) { and then just use $foo instead :) > + push @$param, '--entries-max', $opts->{"pbs-entries-max"}; > + $self->loginfo("set max number of entries in memory for file-based backups to $opts->{'pbs-entries-max'}"); Style nit: line longer than 100 characters > + } > + > my @storage = ($opts->{scfg}, $opts->{storage}); > > my $logfunc = sub { my $line = shift; $self->loginfo($line) };