From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6302A745C4 for ; Mon, 21 Jun 2021 17:32:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 502E41E4F8 for ; Mon, 21 Jun 2021 17:31:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 342D21E4E8 for ; Mon, 21 Jun 2021 17:31:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0121640C0A for ; Mon, 21 Jun 2021 17:31:32 +0200 (CEST) Message-ID: Date: Mon, 21 Jun 2021 17:31:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210621135534.14807-1-d.csapak@proxmox.com> <20210621135534.14807-3-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210621135534.14807-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.710 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH common 1/3] SysFSTools: add verbose flag to pci_device_info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 15:32:03 -0000 On 21.06.21 15:55, Dominik Csapak wrote: > to also get the subsystem_vendor and device, as well as the > iommu group and mediated device support > > Signed-off-by: Dominik Csapak > --- > src/PVE/SysFSTools.pm | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) > applied, thanks - one question below though. > @@ -225,6 +227,25 @@ sub pci_device_info { > has_fl_reset => -f "$pcisysfs/devices/$name/reset" || 0, > }; > > + if ($verbose) { > + my $sub_vendor = file_read_firstline("$devdir/subsystem_vendor"); > + $sub_vendor =~ s/^0x// if defined($sub_vendor); > + my $sub_device = file_read_firstline("$devdir/subsystem_device"); > + $sub_device =~ s/^0x// if defined($sub_device); > + > + $res->{subsystem_vendor} = $sub_vendor if defined($sub_vendor); > + $res->{subsystem_device} = $sub_device if defined($sub_device); > + > + if (-e "$devdir/iommu_group") { > + my ($iommugroup) = (readlink("$devdir/iommu_group") =~ m/\/(\d+)$/); > + $res->{iommugroup} = int($iommugroup); just to be sure: int() warns if it gets an undefined value, but I'd guess that once "$devdir/iommu_group" exists it's basically guaranteed that we get the integer match at end-of-string above?