From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9702D62592 for ; Fri, 11 Feb 2022 14:01:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D7AE2973E for ; Fri, 11 Feb 2022 14:01:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 137A529735 for ; Fri, 11 Feb 2022 14:01:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E1D5846DF0 for ; Fri, 11 Feb 2022 14:01:48 +0100 (CET) Message-ID: Date: Fri, 11 Feb 2022 14:01:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20220209130750.902245-1-f.gruenbichler@proxmox.com> <20220209130750.902245-18-f.gruenbichler@proxmox.com> From: Fabian Ebner In-Reply-To: <20220209130750.902245-18-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.135 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v5 qemu-server 10/11] api: add remote migrate endpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 13:01:49 -0000 Am 09.02.22 um 14:07 schrieb Fabian Grünbichler: > @@ -4016,6 +4016,206 @@ __PACKAGE__->register_method({ > > }}); > > +__PACKAGE__->register_method({ > + name => 'remote_migrate_vm', > + path => '{vmid}/remote_migrate', > + method => 'POST', > + protected => 1, > + proxyto => 'node', > + description => "Migrate virtual machine to a remote cluster. Creates a new migration task.", > + permissions => { > + check => ['perm', '/vms/{vmid}', [ 'VM.Migrate' ]], > + }, > + parameters => { > + additionalProperties => 0, > + properties => { > + node => get_standard_option('pve-node'), > + vmid => get_standard_option('pve-vmid', { completion => \&PVE::QemuServer::complete_vmid }), > + 'target-vmid' => get_standard_option('pve-vmid', { optional => 1 }), > + 'target-endpoint' => get_standard_option('proxmox-remote', { > + description => "Remote target endpoint", > + }), > + online => { > + type => 'boolean', > + description => "Use online/live migration if VM is running. Ignored if VM is stopped.", > + optional => 1, > + }, > + 'with-local-disks' => { > + type => 'boolean', > + description => "Enable live storage migration for local disk", > + optional => 1, > + }, Shouldn't this simply always be true, rather than an optional parameter? > + delete => { > + type => 'boolean', > + description => "Delete the original VM and related data after successful migration. By default the original VM is kept on the source cluster in a stopped state.", > + optional => 1, > + default => 0, > + }, > + 'target-storage' => get_standard_option('pve-targetstorage', { > + completion => \&PVE::QemuServer::complete_migration_storage, > + optional => 0, > + }), Style nit: indentation is wrong > + 'target-bridge' => { > + type => 'string', > + description => "Mapping from source to target bridges. Providing only a single bridge ID maps all source bridges to that bridge. Providing the special value '1' will map each source bridge to itself.", > + format => 'bridge-pair-list', > + }, Same two comments apply to the next patch.