From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4DF1A911CA for ; Fri, 17 Mar 2023 14:17:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 286581A15B for ; Fri, 17 Mar 2023 14:17:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 17 Mar 2023 14:17:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DE7064516B for ; Fri, 17 Mar 2023 14:17:17 +0100 (CET) Message-ID: Date: Fri, 17 Mar 2023 14:17:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US From: Matthias Heiserer To: Proxmox VE development discussion Reply-To: Proxmox VE development discussion References: <20230125112932.127145-1-m.heiserer@proxmox.com> <20230125112932.127145-2-m.heiserer@proxmox.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.612 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2023 13:17:49 -0000 On 15.03.2023 12:51, Matthias Heiserer wrote: > On 15.03.2023 12:10, Dominik Csapak wrote: >> hi not sure we would want to do it this way, since >> this will only work for the node where the new pve-cluster >> is installed, the other nodes will not be able to update their >> local database with the info from the new nodes >> >> AFAIR, the way we dealt with rrd updates in the past is >> that we introduced a new db (like pve2.3-vm) which is also >> not available on older nodes, but it does not error out, since >> it won't match and we don't try to update it > I thought I had tested that and it would just discard the value, instead > of erroring. but I'll check again, not sure rn tested it, it indeed does not work, but no error is being logged i guess a separate db is the next best option >> >> On 1/25/23 12:29, Matthias Heiserer wrote: >>> To modify the existing rrd store, rrdtool is required >>> >>> Signed-off-by: Matthias Heiserer >>> --- >>>   data/src/status.c           | 1 + >>>   debian/control              | 1 + >>>   debian/pve-cluster.postinst | 6 ++++++ >>>   3 files changed, 8 insertions(+) >>>   create mode 100644 debian/pve-cluster.postinst >>> >>> diff --git a/data/src/status.c b/data/src/status.c >>> index 5e1e841..9290141 100644 >>> --- a/data/src/status.c >>> +++ b/data/src/status.c >>> @@ -1130,6 +1130,7 @@ static const char *rrd_def_node[] = { >>>       "DS:rootused:GAUGE:120:0:U", >>>       "DS:netin:DERIVE:120:0:U", >>>       "DS:netout:DERIVE:120:0:U", >>> +    "DS:arcsize:GAUGE:120:0:U", >>>       "RRA:AVERAGE:0.5:1:70", // 1 min avg - one hour >>>       "RRA:AVERAGE:0.5:30:70", // 30 min avg - one day >>> diff --git a/debian/control b/debian/control >>> index 2d5a01f..22d96c2 100644 >>> --- a/debian/control >>> +++ b/debian/control >>> @@ -37,6 +37,7 @@ Depends: corosync (>= 2.3.4-1), >>>            libsqlite3-0, >>>            sqlite3, >>>            systemd, >>> +         rrdtool, >>>            ${misc:Depends}, >>>            ${perl:Depends}, >>>            ${shlibs:Depends}, >>> diff --git a/debian/pve-cluster.postinst b/debian/pve-cluster.postinst >>> new file mode 100644 >>> index 0000000..cf475cc >>> --- /dev/null >>> +++ b/debian/pve-cluster.postinst >>> @@ -0,0 +1,6 @@ >>> +#!/bin/bash >>> + >>> +RRD_DB="/var/lib/rrdcached/db/pve2-node/`hostname`" >>> +if [ -f $RRD_DB ] && [ `rrdtool info $RRD_DB | grep -q arcsize` ]; then >>> +        rrdtool tune $RRD_DB 'DS:arcsize:GAUGE:120:0:U' >>> +fi >> >> >> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >> >> > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel