From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.reiter@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id C7839607A9
 for <pve-devel@pve.proxmox.com>; Tue,  1 Dec 2020 11:38:44 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B4F75FBCD
 for <pve-devel@pve.proxmox.com>; Tue,  1 Dec 2020 11:38:14 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 838A4FB77
 for <pve-devel@pve.proxmox.com>; Tue,  1 Dec 2020 11:38:13 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B57C44258
 for <pve-devel@pve.proxmox.com>; Tue,  1 Dec 2020 11:38:13 +0100 (CET)
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Dietmar Maurer <dietmar@proxmox.com>, Moayad Almalat
 <m.almalat@proxmox.com>, pve-devel@pve.proxmox.com
References: <20201201093450.101063-1-m.almalat@proxmox.com>
 <2008660606.415.1606815696786@webmail.proxmox.com>
 <136819029.416.1606815773304@webmail.proxmox.com>
From: Stefan Reiter <s.reiter@proxmox.com>
Message-ID: <e4dedf77-d80f-f5cf-ce53-236b3423d0df@proxmox.com>
Date: Tue, 1 Dec 2020 11:38:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.3
MIME-Version: 1.0
In-Reply-To: <136819029.416.1606815773304@webmail.proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.033 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-manager]: api2:/cluster return intiger
 format for VMID
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 01 Dec 2020 10:38:44 -0000

On 01/12/2020 10:42, Dietmar Maurer wrote:
> 
>> On 12/01/2020 10:41 AM Dietmar Maurer <dietmar@proxmox.com> wrote:
>>
>>   
>>>   	for (my $i = 100; $i < 10000; $i++) {
>>> -	    return $i if !defined($idlist->{$i});
>>> +	    return int($i) if !defined($idlist->{$i});
>>
>> IMO, this does not solve the problem, because $i is already and int.
> 
> or does $idlist->{$i} converts $i to string??
> 

Without testing anything, just my two cents, but we previously had the 
issue where the JSON formatter in Perl would format a value based on 
it's last usage context - and in case of a hash access that's probably a 
string, even if $i "is" an int.