From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1AC6DBB0FC for ; Fri, 22 Mar 2024 15:54:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE0E883B5 for ; Fri, 22 Mar 2024 15:54:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Mar 2024 15:54:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0931541A52 for ; Fri, 22 Mar 2024 15:54:04 +0100 (CET) Message-ID: Date: Fri, 22 Mar 2024 15:54:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20240320125158.2094900-1-d.csapak@proxmox.com> <20240320125158.2094900-2-d.csapak@proxmox.com> From: Fiona Ebner In-Reply-To: <20240320125158.2094900-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 1/3] stop cleanup: remove unnecessary tpmstate cleanup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2024 14:54:05 -0000 Am 20.03.24 um 13:51 schrieb Dominik Csapak: > tpmstate0 is already included in `get_vm_volumes`, and our only storage > plugin that has unmap_volume implemented is the RBDPlugin, where we call > unmap in `deactivate_volume`. So it's already ummapped by the > `deactivate_volumes` calls above. > > Signed-off-by: Dominik Csapak > --- There are third-party storage plugins too. But it's natural to expect that deactivate_volume() would also remove a mapping for the volume. OTOH, there is an explicit map_volume() call in start_swtpm() (can't use librbd), so it's natural to expect an explicit unmap_volume() call. However, the order of calls right now is 1. activate_volume() 2. map_volume() 3. deactivate_volume() 4. unmap_volume() I'd rather expect 3 and 4 to be swapped if doing it "properly". All that said, I think we can try dropping this and risk the, arguably unlikely, scenario that a third-party plugin breaks. If it really happens, then we can adapt according to the actual needs. Acked-by: Fiona Ebner > PVE/QemuServer.pm | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index ef3aee20..d53e9693 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -6167,14 +6167,6 @@ sub vm_stop_cleanup { > if (!$keepActive) { > my $vollist = get_vm_volumes($conf); > PVE::Storage::deactivate_volumes($storecfg, $vollist); > - > - if (my $tpmdrive = $conf->{tpmstate0}) { > - my $tpm = parse_drive("tpmstate0", $tpmdrive); > - my ($storeid, $volname) = PVE::Storage::parse_volume_id($tpm->{file}, 1); > - if ($storeid) { > - PVE::Storage::unmap_volume($storecfg, $tpm->{file}); > - } > - } > } > > foreach my $ext (qw(mon qmp pid vnc qga)) {