From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B9418706B7 for ; Mon, 6 Sep 2021 09:06:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A841CC5CC for ; Mon, 6 Sep 2021 09:05:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 20E19C5BD for ; Mon, 6 Sep 2021 09:05:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DBE53445A6 for ; Mon, 6 Sep 2021 09:05:27 +0200 (CEST) Message-ID: Date: Mon, 6 Sep 2021 09:04:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Thunderbird/92.0 Content-Language: en-US To: Proxmox VE development discussion , Lorenz Stechauner References: <20210831101637.3080902-1-l.stechauner@proxmox.com> <20210831101637.3080902-3-l.stechauner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210831101637.3080902-3-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.316 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v4 storage 1/4] status: move unlink from http-server to enpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Sep 2021 07:06:04 -0000 meh, only noticed the s/enpoint/endpoint/ spelling error in the subject after pushing it out.. On 31.08.21 12:16, Lorenz Stechauner wrote: > this is the first step in which not the http server removes the > temporary file, but the worker itself. > > Signed-off-by: Lorenz Stechauner > --- > PVE/API2/Storage/Status.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm > index b838461..cc8ed5a 100644 > --- a/PVE/API2/Storage/Status.pm > +++ b/PVE/API2/Storage/Status.pm > @@ -486,6 +486,12 @@ __PACKAGE__->register_method ({ > print "command: " . join(' ', @$cmd) . "\n"; > > eval { run_command($cmd, errmsg => 'import failed'); }; > + > + # unlinks only the temporary file from the http server this is just describing what I can read from the code below anyway? And it implies to me that it removes the file from some directory a http server serves. I adapted this trying to give a slightly better hint for a "why?". "the temporary file got only uploaded locally, no need to rm remote" > + unlink $tmpfilename; > + warn "unable to clean up temporary file '$tmpfilename' - $!\n" > + if $! && $! != ENOENT; nit: I used a single line in the follow-up as I touched the area anyway (wouldn't have cared to much else). I also updated the style guide wiki slightly to reflect that post-if's are most often fine to use the upper limit of 100cc text-width as their main use is short/concise error handling anyway. But as said more of a nit from my side. > + > if (my $err = $@) { > eval { $err_cleanup->() }; > warn "$@" if $@; >