From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3AF17937F8 for ; Thu, 5 Jan 2023 14:51:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D09B38FC for ; Thu, 5 Jan 2023 14:51:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 5 Jan 2023 14:51:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 38026440B5 for ; Thu, 5 Jan 2023 14:51:11 +0100 (CET) Message-ID: Date: Thu, 5 Jan 2023 14:51:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 From: Fiona Ebner To: pve-devel@lists.proxmox.com, c.ebner@proxmox.com References: <20230105091804.156599-1-c.ebner@proxmox.com> <20230105091804.156599-2-c.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20230105091804.156599-2-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.492 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.939 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [RFC firewall] api: Add optional parameters `since` and `until` for timestamp filter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2023 13:51:43 -0000 Just two refreshers about style ;) Am 05.01.23 um 10:18 schrieb Christian Ebner: > The optional unix epoch timestamps parameters `since` and `until` are introduced in order to filter > firewall logs files. > > Since the `dump_logfile` function is used in multiple places, not neccessarily following the firewall > log output format, a specialized function `dump_fw_logfile` is introduced in the PVE::Tools, > with fallback to the previous `dump_logfile` function if none of the parameters is present. > > This patch depends on the corresponding patch in the pve-common repository. > Style nit: lines in the commit message should be <= 70 characters [0] > @@ -197,7 +209,8 @@ __PACKAGE__->register_method({ > my $user = $rpcenv->get_user(); > my $node = $param->{node}; > > - my ($count, $lines) = PVE::Tools::dump_logfile("/var/log/pve-firewall.log", $param->{start}, $param->{limit}); > + my($count, $lines) = PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log", > + $param->{start}, $param->{limit}, undef, $param->{since}, $param->{until}); Style nit: please use 1 line for each parameter if it gets too long [1] > @@ -201,9 +213,9 @@ sub register_handlers { > my $user = $rpcenv->get_user(); > my $vmid = $param->{vmid}; > > - my ($count, $lines) = PVE::Tools::dump_logfile("/var/log/pve-firewall.log", > - $param->{start}, $param->{limit}, > - "^$vmid "); > + my ($count, $lines) = PVE::Tools::dump_fw_logfile("/var/log/pve-firewall.log", > + $param->{start}, $param->{limit}, "^$vmid ", $param->{since}, > + $param->{until}); Same here [0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages [1]: https://pve.proxmox.com/wiki/Perl_Style_Guide#Wrapping_Arguments