From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2C6806CC53 for ; Wed, 31 Mar 2021 10:26:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 275D1C28D for ; Wed, 31 Mar 2021 10:26:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 17D94C27E for ; Wed, 31 Mar 2021 10:26:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D7EE943506 for ; Wed, 31 Mar 2021 10:26:26 +0200 (CEST) Message-ID: Date: Wed, 31 Mar 2021 10:26:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210322143243.6606-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210322143243.6606-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm] Subject: [pve-devel] applied: [PATCH storage 1/4] Revert "vdisk list: only collect images from storages with an appropriate content type" X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2021 08:26:58 -0000 On 22.03.21 15:32, Fabian Ebner wrote: > This reverts commit a44c18925d223a971296801a0985db34707ada4d and adds a reminder > comment. > > The mentioned commit is actually a backwards-incompatible change that leads to > slightly different behavior when migrating a VM with volumes on a misconfigured > storage. For example, unreferenced volumes on a misconfigured storage won't be > picked up, even though they were before. And for referenced volumes on a > misconfigured storage, the disk size would not be updated on migration anymore. > > We should wait until the next major release for this change and then also > re-evaluate the migration behavior with misconfigured disks. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > applied, thanks!