From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id BB47A1FF56B
	for <inbox@lore.proxmox.com>; Mon, 22 Apr 2024 15:16:48 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B66C112688;
	Mon, 22 Apr 2024 15:16:53 +0200 (CEST)
Message-ID: <e422ad73-49ef-4598-92c1-f7a15419cec2@proxmox.com>
Date: Mon, 22 Apr 2024 15:16:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Fiona Ebner <f.ebner@proxmox.com>, Markus Frank <m.frank@proxmox.com>
References: <20240415085002.665246-1-m.frank@proxmox.com>
 <0f77e682-8177-472b-907f-b1f18be745d3@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <0f77e682-8177-472b-907f-b1f18be745d3@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.015 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu
 ComboBox
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 4/22/24 15:11, Fiona Ebner wrote:
> Am 15.04.24 um 10:50 schrieb Markus Frank:
>> Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM.
>> If i440fx is selected, another ComboBox will be enabled/visible that does not
>> have the Intel option, as Intel-vIOMMU is not compatible with i440fx.
>>
> 
just applied both patches here, so i'm replying

> Just wondering, is it possible to bind the comboItems instead of having
> two different comboboxes?

no thats currently not possible, since the comboitems become a store with records
changing the comboItems after initialization does not do anything

(we could change that of course, but this is good enough for now imo)

> 
> Should we display some hint that Intel can/should also be used even if
> you have an AMD? Maybe even just in the text we display, like "Intel
> (also used for AMD)" but hope somebody can come up with something better.
> 
> 

mhh.. i mean it is a virtual device, so should we also add this info
for e.g. e1000 devices?

since it's in the advanced section and it is documented in pve-docs,
i'd leave it out here (we can still add a notice later if users
are confused, but most users won't use/need it anyway)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel