From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D27C671AB5 for ; Fri, 13 May 2022 10:00:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C79462F074 for ; Fri, 13 May 2022 10:00:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0F4412F068 for ; Fri, 13 May 2022 10:00:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C0A37434D3 for ; Fri, 13 May 2022 10:00:38 +0200 (CEST) Message-ID: Date: Fri, 13 May 2022 10:00:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Thunderbird/101.0 Content-Language: en-GB To: Daniel Tschlatscher , Proxmox VE development discussion References: <20220506123910.146775-1-d.tschlatscher@proxmox.com> <1390d06b-f06a-2518-8d99-5cb074abb9f2@proxmox.com> <56094244-2673-e153-7945-2063767cd189@proxmox.com> From: Thomas Lamprecht In-Reply-To: <56094244-2673-e153-7945-2063767cd189@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 1.464 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.888 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied: [PATCH manager v2] fix #3994: Options menu entry in the System menu X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 08:00:40 -0000 Am 5/13/22 um 09:55 schrieb Daniel Tschlatscher: > On 5/12/22 17:13, Thomas Lamprecht wrote: >> Some other points to improve: >> >> - setting the online help, maybe to 'proxmox_node_management' which wo= uld make >> =C2=A0=C2=A0 it point to: >> =C2=A0=C2=A0 https://pve.proxmox.com/pve-docs/chapter-sysadmin.html#pr= oxmox_node_management >> =C2=A0=C2=A0 (the chapter could maybe do good with some addition w.r.t= =2E first start delay >=20 > This sounds to me like a suggestion to set the online help for the pane= l, i.e. the > button in the top right corner. But that's already included in the patc= h. > Or are you suggesting to put it somewhere else too? None of the edit windows have it set. the top right corner is somewhat ni= ce sometimes but the real useful one is the one from the edit window, which = is much more visible, and especially the only one available if the window is= open as the background is masked then, having to close the window with some va= lues already half entered is the worst. >=20 >> >> - It's not clear what unit the start delay has, you could mention that= explicitly, >> =C2=A0=C2=A0 simplest way to do so is adding a ' (s)' to the fieldLabe= l after the gettext. >=20 > The field does not display a value while displaying Default, though it = explicitly states > 'Seconds' after any value is set. I think it would become very clear to= anybody then That's too late, I need to know what I'm entering *on entering* not somet= imes later, when I already set a possible bogus value; while it hasn't that bi= g of an affect in this specific case it should be the general approach to U= X that the user knows what they enter, otherwise a UI is close to useless. > what unit this setting represents. > Still, adding ' (s)' probably wouldn't kill me either. =F0=9F=98=89 Note that the "Default" in the grid is also wrong for unset, it should st= ate "None".