From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EDD9E1FF389 for ; Wed, 8 May 2024 17:00:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D5CC2E7B; Wed, 8 May 2024 17:00:40 +0200 (CEST) Message-ID: Date: Wed, 8 May 2024 17:00:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Dominik Csapak References: <20240508125418.2598112-1-d.csapak@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20240508125418.2598112-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [RFC PATCH manager] ui: make label for mediated device types more clear X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 08/05/2024 14:54, Dominik Csapak wrote: > 'MDev' could be interpreted as either 'Mediated Device' or 'Mapped > Device', which can confuse users. > > At least one user was confused: > https://forum.proxmox.com/threads/146586/#post-662091 > > Fix that by writing out 'Mediated Device'. > > Signed-off-by: Dominik Csapak > --- > sending as RFC because the text is now too long for one line, which is > bad IMHO, but I could not come up with a better text that fits, maybe > someone else has a better idea (or we leave it as is) > > > www/manager6/qemu/PCIEdit.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/qemu/PCIEdit.js b/www/manager6/qemu/PCIEdit.js > index 8cef1b10..940e017c 100644 > --- a/www/manager6/qemu/PCIEdit.js > +++ b/www/manager6/qemu/PCIEdit.js > @@ -262,7 +262,7 @@ Ext.define('PVE.qemu.PCIInputPanel', { > name: 'mdev', > reference: 'mdev', > disabled: true, > - fieldLabel: gettext('MDev Type'), > + fieldLabel: gettext('Mediated Device Type'), Alternatively you could add just a tooltip here, not a perfect solution either but better than nothing for most users. While it does not solve the wrapping, could we drop the "type" part, as is this really a type of something or a selection a specific mediated device? One idea would be a bigger re-layout, i.e.: move the radio groups beside each other so that they and their selection combobox take up the first two rows, in the row below you could then place the two checkboxes "all functions" and "primary GPU", and as bbar (above the advanced section) you could have the mdev field with a wider label, at the bottom it might not look that bad even if a bit asymmetric to the other fields. One would have to try and play around to see if that is an improvement, if not, having a label wrap over is probably the lesser evil compared to bad UX due to the label being a tad cryptic. > nodename: me.nodename, > listeners: { > change: function(field, value) { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel