From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5FA211FF162 for <inbox@lore.proxmox.com>; Mon, 7 Apr 2025 10:18:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5619438634; Mon, 7 Apr 2025 10:18:45 +0200 (CEST) Message-ID: <e2ae45b6-0629-4d40-b642-54ea39df1286@proxmox.com> Date: Mon, 7 Apr 2025 10:18:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20241204113708.50043-1-f.ebner@proxmox.com> <20241204113708.50043-3-f.ebner@proxmox.com> <66547236-ef82-4500-a1a7-153226d03cba@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <66547236-ef82-4500-a1a7-153226d03cba@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] superseded: [PATCH manager 2/5] user: password edit: clarify that password changes for PAM realm only apply to local node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 06.04.25 um 20:01 schrieb Thomas Lamprecht: > Am 04.12.24 um 12:37 schrieb Fiona Ebner: >> Reported in the community forum: >> https://forum.proxmox.com/threads/158518/ >> >> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> >> --- >> www/manager6/dc/UserView.js | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js >> index 82bd2ee7..d5844674 100644 >> --- a/www/manager6/dc/UserView.js >> +++ b/www/manager6/dc/UserView.js >> @@ -68,10 +68,16 @@ Ext.define('PVE.dc.UserView', { >> return false; >> }, >> handler: function(btn, event, rec) { >> + let hintHtml; >> + if (rec.data['realm-type'] === 'pam') { >> + hintHtml = gettext("For the PAM realm, this only applies to the local node."); > > I'd switch the place of `only` and `applies` and maybe s/local/connected/, > like: > > For the PAM realm, this applies only to the connected node. > >> + } >> + >> Ext.create('Proxmox.window.PasswordEdit', { >> userid: rec.data.userid, >> confirmCurrentPassword: Proxmox.UserName !== 'root@pam', >> autoShow: true, >> + hintHtml: hintHtml, > > FYI, if variable name and property name match, i.e., left part of the colon is > the same as the right part, you can just use that directly, e.g. `{ hintHtml }` > is the same as `{ hintHtml: hintHtml }`; but not something that needs to be > used as of now, but would be fine to be used. > >> minLength: 8, >> listeners: { >> destroy: () => reload(), > Sent a v2: https://lore.proxmox.com/pve-devel/20250407081657.23658-1-f.ebner@proxmox.com/ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel