From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 228716BDE1 for ; Tue, 21 Sep 2021 15:32:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F636EED7 for ; Tue, 21 Sep 2021 15:32:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F0C21EEC7 for ; Tue, 21 Sep 2021 15:32:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C3C3A44A0C for ; Tue, 21 Sep 2021 15:32:09 +0200 (CEST) Message-ID: Date: Tue, 21 Sep 2021 15:31:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210921112208.48084-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210921112208.48084-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.253 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series-partially: [PATCH-SERIES v2 manager] ui: some backup job improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2021 13:32:41 -0000 On 21.09.21 13:22, Fabian Ebner wrote: > The only thing remaining from v1 is adding a cluster-wide storage > selector for the cluster-wide backup job editor. > > The new approach is to re-use the existing storage selector and add > a config option to enable cluster-wide selection. > > > Changes from v1: > * Dropped already applied patches. > * Extend existing storage selector to also support a cluster view > instead of adding a new storage selector. > > > pve-manager: > > Fabian Ebner (4): > ui: storage selector: only check for nodename before loading storage > ui: storage selector: add new clusterView option > ui: cluster backup: only restrict storages to node when it's selected > ui: storage selector: use storage type renderer > > www/manager6/dc/Backup.js | 4 +- > www/manager6/form/StorageSelector.js | 109 +++++++++++++++++++++------ > 2 files changed, 88 insertions(+), 25 deletions(-) > applied all but the last one, I get where you come from but this is just to much wasted space most of the time IMO, especially in the non-backup job cases, as there we can never have a PBS and the other storage type names are all quite a bit shorter.. anyhow, thanks for the other stuff!