From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 2E0321FF165
	for <inbox@lore.proxmox.com>; Thu, 24 Apr 2025 14:02:44 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id ABAB56962;
	Thu, 24 Apr 2025 14:02:51 +0200 (CEST)
Message-ID: <e1c0bd1a-dbdb-4f0d-92f0-e8cd55607e94@proxmox.com>
Date: Thu, 24 Apr 2025 14:02:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Christoph Heiss <c.heiss@proxmox.com>
References: <20250424111941.730528-1-c.heiss@proxmox.com>
 <20250424111941.730528-7-c.heiss@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20250424111941.730528-7-c.heiss@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.036 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server v2 6/13] api2: qemu: add module
 exposing node migration capabilities
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 24.04.25 um 13:19 schrieb Christoph Heiss:
> diff --git a/PVE/API2/Qemu/Migration.pm b/PVE/API2/Qemu/Migration.pm
> new file mode 100644
> index 00000000..34125a15
> --- /dev/null
> +++ b/PVE/API2/Qemu/Migration.pm
> @@ -0,0 +1,46 @@
> +package PVE::API2::Qemu::Migration;

(Sorry, answered to v1 accidentally before)

Would be nice to have the package name reflect that this is only for
node-side capabilities and not the QEMU-side migration capabilities.
Maybe PVE::API2::NodeCapabilities::Qemu::Migration?

Otherwise, there will be a conflict if we move the other
migration-related API endpoints into a dedicated module, because the API
paths here and there have different parents. For that module, the name
PVE::API2::Qemu::Migration would be most fitting.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel