From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1E3401FF141 for ; Fri, 27 Feb 2026 14:19:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3937511D67; Fri, 27 Feb 2026 14:19:59 +0100 (CET) Date: Fri, 27 Feb 2026 14:19:53 +0100 From: Gabriel Goller To: Stefan Hanreich Subject: Re: [PATCH proxmox-ve-rs 8/9] frr: add bgp support with templates and serialization Message-ID: Mail-Followup-To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260203160246.353351-1-g.goller@proxmox.com> <20260203160246.353351-9-g.goller@proxmox.com> <6c18cedd-3c78-4219-bf9c-ca9870021518@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6c18cedd-3c78-4219-bf9c-ca9870021518@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772198374394 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.158 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.306 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.668 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6NIYDJMDAE3OUFXGXZZAZN6TTOQQS2NV X-Message-ID-Hash: 6NIYDJMDAE3OUFXGXZZAZN6TTOQQS2NV X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 27.02.2026 12:56, Stefan Hanreich wrote: > On 2/3/26 5:01 PM, Gabriel Goller wrote: > > [snip] > > diff --git a/proxmox-frr-templates/templates/bgp_router.jinja b/proxmox-frr-templates/templates/bgp_router.jinja > > new file mode 100644 > > index 000000000000..6f48d6ca17a4 > > --- /dev/null > > +++ b/proxmox-frr-templates/templates/bgp_router.jinja > > @@ -0,0 +1,118 @@ > > +{% macro address_family_common(common_address_family) -%} > > +{% for vrf in common_address_family.import_vrf %} > > + import vrf {{ vrf }} > > +{% endfor %} > > +{% for neighbor in common_address_family.neighbors %} > > + neighbor {{ neighbor.name }} activate > > + {% if neighbor.soft_reconfiguration_inbound %} > > + neighbor {{ neighbor.name }} soft-reconfiguration inbound > > + {% endif %} > > + {% if neighbor.route_map_in %} > > + neighbor {{ neighbor.name }} route-map {{ neighbor.route_map_in }} in > > + {% endif %} > > + {% if neighbor.route_map_out %} > > + neighbor {{ neighbor.name }} route-map {{ neighbor.route_map_out }} out > > + {% endif %} > > +{% endfor -%} > > +{% for line in common_address_family.custom_frr_config %} > > +{{ line }} > > +{% endfor -%} > > +{% endmacro -%} > > +{% macro bgp_router(router_config) %} > > + bgp router-id {{ router_config.router_id }} > > + no bgp hard-administrative-reset > > this option should be exposed and not hardcoded > > > +{% if router_config.default_ipv4_unicast == false %} > > + no bgp default ipv4-unicast > > +{% endif %} > > +{% if router_config.coalesce_time %} > > + coalesce-time {{ router_config.coalesce_time }} > > +{% endif %} > > + no bgp graceful-restart notification > > here as well Agree.