From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 74F8F1FF16F for ; Tue, 22 Jul 2025 14:12:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B641B8B2A; Tue, 22 Jul 2025 14:13:41 +0200 (CEST) Date: Tue, 22 Jul 2025 14:13:37 +0200 From: Wolfgang Bumiller To: Fiona Ebner Message-ID: References: <20250721121124.77526-1-f.ebner@proxmox.com> <20250721121124.77526-3-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250721121124.77526-3-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753186408966 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.424 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Subject: Re: [pve-devel] [PATCH storage 2/9] plugin: add get_formats() method and use it instead of default_format() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" bWlub3Igbml0IGJ1dCB0aGUgd2hvbGUgc3RvcmFnZSBzaWRlIExHVE0KCk9uIE1vbiwgSnVsIDIx LCAyMDI1IGF0IDAyOjEwOjQ3UE0gKzAyMDAsIEZpb25hIEVibmVyIHdyb3RlOgo+IFRoZSBMVk0g cGx1Z2luIGNhbiBvbmx5IHVzZSBxY293MiBmb3JtYXQgd2hlbiB0aGUKPiAnc25hcHNob3QtYXMt dm9sdW1lLWNoYWluJyBjb25maWd1cmF0aW9uIG9wdGlvbiBpcyBzZXQuIFRoZSBmb3JtYXQKPiBp bmZvcm1hdGlvbiBpcyBjdXJyZW50bHkgb25seSByZWNvcmRlZCBzdGF0aWNhbGx5IGluIHRoZSBw bHVnaW4gZGF0YS4KPiBUaGlzIGNhdXNlcyBpc3N1ZXMsIGZvciBleGFtcGxlLCByZXN0b3Jpbmcg YSBndWVzdCB2b2x1bWUgdGhhdCB1c2VzCj4gcWNvdzIgYXMgYSBmb3JtYXQgaGludCBvbiBhbiBM Vk0gc3RvcmFnZSB3aXRob3V0IHRoZSBvcHRpb24gc2V0IHdpbGwKPiBmYWlsLCBiZWNhdXNlIHRo ZSBwbHVnaW4gZGF0YSBpbmRpY2F0ZXMgdGhhdCBxY293MiBpcyBzdXBwb3J0ZWQuCj4gSW50cm9k dWNlIGEgZGVkaWNhdGVkIG1ldGhvZCwgc28gdGhhdCBwbHVnaW5zIGNhbiBpbmRpY2F0ZSB3aGF0 Cj4gYWN0dWFsbHkgaXMgc3VwcG9ydGVkIGFjY29yZGluZyB0byB0aGUgc3RvcmFnZSBjb25maWd1 cmF0aW9uLgo+IAo+IFRoZSBpbXBsZW1lbnRhdGlvbiBmb3IgTFZNIGlzIGRvbmUgaW4gYSBzZXBh cmF0ZSBjb21taXQuCj4gCj4gUmVtb3ZlIHRoZSBub3cgdW51c2VkIGRlZmF1bHRfZm9ybWF0KCkg ZnVuY3Rpb24gZnJvbSBQbHVnaW4ucG0uCj4gCj4gU2lnbmVkLW9mZi1ieTogRmlvbmEgRWJuZXIg PGYuZWJuZXJAcHJveG1veC5jb20+Cj4gLS0tCj4gIEFwaUNoYW5nZUxvZyAgICAgICAgICAgICAg fCAgOCArKysrKysKPiAgc3JjL1BWRS9TdG9yYWdlLnBtICAgICAgICB8IDE5ICsrKysrKystLS0t LS0KPiAgc3JjL1BWRS9TdG9yYWdlL1BsdWdpbi5wbSB8IDU5ICsrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKyks IDI3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9BcGlDaGFuZ2VMb2cgYi9BcGlDaGFu Z2VMb2cKPiBpbmRleCAwOTg0YWZiLi5kODBiZmIzIDEwMDY0NAo+IC0tLSBhL0FwaUNoYW5nZUxv Zwo+ICsrKyBiL0FwaUNoYW5nZUxvZwo+IEBAIC00OSw2ICs0OSwxNCBAQCBGdXR1cmUgY2hhbmdl cyBzaG91bGQgYmUgZG9jdW1lbnRlZCBpbiBoZXJlLgo+ICAgICAgICBOT1RFOiBTdG9yYWdlcyBt dXN0IHN1cHBvcnQgdXNpbmcgImN1cnJlbnQiIGFzIGEgc3BlY2lhbCBuYW1lIGluIGByZW5hbWVf c25hcHNob3QoKWAgdG8KPiAgICAgICAgY2hlYXBseSBjb252ZXJ0IGEgc25hcHNob3QgaW50byB0 aGUgY3VycmVudCBkaXNrIHN0YXRlIGFuZCBiYWNrLgo+ICAKPiArKiBJbnRyb2R1Y2UgYGdldF9m b3JtYXRzKClgIHBsdWdpbiBtZXRob2QKPiArCj4gKyAgR2V0IGluZm9ybWF0aW9uIGFib3V0IHRo ZSBzdXBwb3J0ZWQgZm9ybWF0cyBhbmQgZGVmYXVsdCBmb3JtYXQgYWNjb3JkaW5nIHRvIHRoZSBj dXJyZW50IHN0b3JhZ2UKPiArICBjb25maWd1cmF0aW9uLiBUaGUgZGVmYXVsdCBpbXBsZW1lbmF0 aW9uIGlzIGJhY2t3YXJkcy1jb21wYXRpYmxlIHdpdGggcHJldmlvdXMgYmVoYXZpb3IgYW5kIGxv b2tzCj4gKyAgYXQgdGhlIGRlZmluaXRpb24gZ2l2ZW4gaW4gdGhlIHBsdWdpbiBkYXRhLCBhcyB3 ZWxsIGFzIHRoZSBgZm9ybWF0YCBzdG9yYWdlIGNvbmZpZ3VyYXRpb24gb3B0aW9uLAo+ICsgIHdo aWNoIGNhbiBvdmVycmlkZSB0aGUgZGVmYXVsdCBmb3JtYXQuIE11c3QgYmUgaW1wbGVtZW50ZWQg d2hlbiB0aGUgc3VwcG9ydGVkIGZvcm1hdHMgb3IgZGVmYXVsdAo+ICsgIGZvcm1hdCBkZXBlbmQg b24gdGhlIHN0b3JhZ2UgY29uZmlndXJhdGlvbi4KPiArCj4gICMjICBWZXJzaW9uIDExOgo+ICAK PiAgKiBBbGxvdyBkZWNsYXJpbmcgc3RvcmFnZSBmZWF0dXJlcyB2aWEgcGx1Z2luIGRhdGEKPiBk aWZmIC0tZ2l0IGEvc3JjL1BWRS9TdG9yYWdlLnBtIGIvc3JjL1BWRS9TdG9yYWdlLnBtCj4gaW5k ZXggNmNhOWY4OC4uMWZhZjg5MyAxMDA3NTUKPiAtLS0gYS9zcmMvUFZFL1N0b3JhZ2UucG0KPiAr KysgYi9zcmMvUFZFL1N0b3JhZ2UucG0KPiBAQCAtODU3LDEwICs4NTcsMTEgQEAgbXkgJHZvbG5h bWVfZm9yX3N0b3JhZ2UgPSBzdWIgewo+ICAKPiAgICAgIG15ICRzY2ZnID0gc3RvcmFnZV9jb25m aWcoJGNmZywgJHN0b3JlaWQpOwo+ICAKPiAtICAgIG15ICh1bmRlZiwgJHZhbGlkX2Zvcm1hdHMp ID0gUFZFOjpTdG9yYWdlOjpQbHVnaW46OmRlZmF1bHRfZm9ybWF0KCRzY2ZnKTsKPiAtICAgIG15 ICRmb3JtYXRfaXNfdmFsaWQgPSBncmVwIHsgJF8gZXEgJGZvcm1hdCB9IEAkdmFsaWRfZm9ybWF0 czsKPiArICAgIG15ICRwbHVnaW4gPSBQVkU6OlN0b3JhZ2U6OlBsdWdpbi0+bG9va3VwKCRzY2Zn LT57dHlwZX0pOwo+ICsKPiArICAgIG15ICRmb3JtYXRzID0gJHBsdWdpbi0+Z2V0X2Zvcm1hdHMo JHNjZmcsICRzdG9yZWlkKTsKPiAgICAgIGRpZSAidW5zdXBwb3J0ZWQgZm9ybWF0ICckZm9ybWF0 JyBmb3Igc3RvcmFnZSB0eXBlICRzY2ZnLT57dHlwZX1cbiIKPiAtICAgICAgICBpZiAhJGZvcm1h dF9pc192YWxpZDsKPiArICAgICAgICBpZiAhJGZvcm1hdHMtPnt2YWxpZH0tPnskZm9ybWF0fTsK PiAgCj4gICAgICAobXkgJG5hbWVfd2l0aG91dF9leHRlbnNpb24gPSAkbmFtZSkgPX4gcy9cLiRm b3JtYXQkLy87Cj4gIAo+IEBAIC0xMTg0LDE0ICsxMTg1LDEyIEBAIHN1YiB2ZGlza19hbGxvYyB7 Cj4gIAo+ICAgICAgJHZtaWQgPSBwYXJzZV92bWlkKCR2bWlkKTsKPiAgCj4gLSAgICBteSAkZGVm Zm9ybWF0ID0gUFZFOjpTdG9yYWdlOjpQbHVnaW46OmRlZmF1bHRfZm9ybWF0KCRzY2ZnKTsKPiAr ICAgIG15ICRwbHVnaW4gPSBQVkU6OlN0b3JhZ2U6OlBsdWdpbi0+bG9va3VwKCRzY2ZnLT57dHlw ZX0pOwo+ICAKPiAtICAgICRmbXQgPSAkZGVmZm9ybWF0IGlmICEkZm10Owo+ICsgICAgJGZtdCA9 ICRwbHVnaW4tPmdldF9mb3JtYXRzKCRzY2ZnLCAkc3RvcmVpZCktPntkZWZhdWx0fSBpZiAhJGZt dDsKPiAgCj4gICAgICBhY3RpdmF0ZV9zdG9yYWdlKCRjZmcsICRzdG9yZWlkKTsKPiAgCj4gLSAg ICBteSAkcGx1Z2luID0gUFZFOjpTdG9yYWdlOjpQbHVnaW4tPmxvb2t1cCgkc2NmZy0+e3R5cGV9 KTsKPiAtCj4gICAgICAjIGxvY2sgc2hhcmVkIHN0b3JhZ2UKPiAgICAgIHJldHVybiAkcGx1Z2lu LT5jbHVzdGVyX2xvY2tfc3RvcmFnZSgKPiAgICAgICAgICAkc3RvcmVpZCwKPiBAQCAtMTY3Myw4 ICsxNjcyLDEyIEBAIHN1YiBzdG9yYWdlX2RlZmF1bHRfZm9ybWF0IHsKPiAgICAgIG15ICgkY2Zn LCAkc3RvcmVpZCkgPSBAXzsKPiAgCj4gICAgICBteSAkc2NmZyA9IHN0b3JhZ2VfY29uZmlnKCRj ZmcsICRzdG9yZWlkKTsKPiArICAgIG15ICRwbHVnaW4gPSBQVkU6OlN0b3JhZ2U6OlBsdWdpbi0+ bG9va3VwKCRzY2ZnLT57dHlwZX0pOwo+ICAKPiAtICAgIHJldHVybiBQVkU6OlN0b3JhZ2U6OlBs dWdpbjo6ZGVmYXVsdF9mb3JtYXQoJHNjZmcpOwo+ICsgICAgbXkgJGZvcm1hdHMgPSAkcGx1Z2lu LT5nZXRfZm9ybWF0cygkc2NmZywgJHN0b3JlaWQpOwo+ICsKPiArICAgIHJldHVybgo+ICsgICAg ICAgIHdhbnRhcnJheSA/ICgkZm9ybWF0cy0+e2RlZmF1bHR9LCBbc29ydCBrZXlzICRmb3JtYXRz LT57dmFsaWR9LT4lKl0pIDogJGZvcm1hdHMtPntkZWZhdWx0fTsKPiAgfQo+ICAKPiAgc3ViIHZn cm91cF9pc191c2VkIHsKPiBkaWZmIC0tZ2l0IGEvc3JjL1BWRS9TdG9yYWdlL1BsdWdpbi5wbSBi L3NyYy9QVkUvU3RvcmFnZS9QbHVnaW4ucG0KPiBpbmRleCBlZjA0Y2IxLi5jM2MxYjYzIDEwMDY0 NAo+IC0tLSBhL3NyYy9QVkUvU3RvcmFnZS9QbHVnaW4ucG0KPiArKysgYi9zcmMvUFZFL1N0b3Jh Z2UvUGx1Z2luLnBtCj4gQEAgLTI4NywyMyArMjg3LDYgQEAgc3ViIHN0b3JhZ2VfaGFzX2ZlYXR1 cmUgewo+ICAgICAgcmV0dXJuOwo+ICB9Cj4gIAo+IC1zdWIgZGVmYXVsdF9mb3JtYXQgewo+IC0g ICAgbXkgKCRzY2ZnKSA9IEBfOwo+IC0KPiAtICAgIG15ICR0eXBlID0gJHNjZmctPnt0eXBlfTsK PiAtICAgIG15ICRkZWYgPSAkZGVmYXVsdERhdGEtPntwbHVnaW5kYXRhfS0+eyR0eXBlfTsKPiAt Cj4gLSAgICBteSAkZGVmX2Zvcm1hdCA9ICdyYXcnOwo+IC0gICAgbXkgJHZhbGlkX2Zvcm1hdHMg PSBbJGRlZl9mb3JtYXRdOwo+IC0KPiAtICAgIGlmIChkZWZpbmVkKCRkZWYtPntmb3JtYXR9KSkg ewo+IC0gICAgICAgICRkZWZfZm9ybWF0ID0gJHNjZmctPntmb3JtYXR9IHx8ICRkZWYtPntmb3Jt YXR9LT5bMV07Cj4gLSAgICAgICAgJHZhbGlkX2Zvcm1hdHMgPSBbc29ydCBrZXlzICV7ICRkZWYt Pntmb3JtYXR9LT5bMF0gfV07Cj4gLSAgICB9Cj4gLQo+IC0gICAgcmV0dXJuIHdhbnRhcnJheSA/ ICgkZGVmX2Zvcm1hdCwgJHZhbGlkX2Zvcm1hdHMpIDogJGRlZl9mb3JtYXQ7Cj4gLX0KPiAtCj4g IFBWRTo6SlNPTlNjaGVtYTo6cmVnaXN0ZXJfZm9ybWF0KCdwdmUtc3RvcmFnZS1wYXRoJywgXCZ2 ZXJpZnlfcGF0aCk7Cj4gIAo+ICBzdWIgdmVyaWZ5X3BhdGggewo+IEBAIC02NDAsNiArNjIzLDQ0 IEBAIHN1YiBwcmVhbGxvY2F0aW9uX2NtZF9vcHQgewo+ICAKPiAgIyBTdG9yYWdlIGltcGxlbWVu dGF0aW9uCj4gIAo+ICs9cG9kCj4gKwoK4oaRIGNhbiBiZSBkcm9wcGVkCgo+ICs9aGVhZDMgZ2V0 X2Zvcm1hdHMKPiArCj4gKyAgICBteSAkZm9ybWF0cyA9ICRwbHVnaW4tPmdldF9mb3JtYXRzKCRz Y2ZnKTsKCuKGkSBtaXNzZXMgdGhlIGAkc3RvcmVpZGAgcGFyYW1ldGVyCgo+ICsgICAgbXkgJGRl ZmF1bHRfZm9ybWF0ID0gJGZvcm1hdHMtPntkZWZhdWx0fTsKPiArICAgIG15ICRpc192YWxpZCA9 ICRmb3JtYXRzLT57dmFsaWR9LT57JGZvcm1hdH0gPyAxIDogMDsKCuKGkSBjb3VsZCBqdXN0IHVz ZSAhISBpbnN0ZWFkIG9mIGA/IDEgOiAwYAoKPiArCj4gK0dldCBpbmZvcm1hdGlvbiBhYm91dCB0 aGUgc3VwcG9ydGVkIGZvcm1hdHMgYW5kIGRlZmF1bHQgZm9ybWF0IGFjY29yZGluZyB0byB0aGUg Y3VycmVudCBzdG9yYWdlCj4gK2NvbmZpZ3VyYXRpb24gQzwkc2NmZz4uIFRoZSByZXR1cm4gdmFs dWUgaXMgYSBoYXNoIHJlZmVyZW5jZSB3aXRoIEM8ZGVmYXVsdD4gbWFwcGluZyB0byB0aGUgZGVm YXVsdAo+ICtmb3JtYXQgYW5kIEM8dmFsaWQ+IG1hcHBpbmcgdG8gYSBoYXNoIHJlZmVyZW5jZSwg d2hlcmUgZWFjaCBzdXBwb3J0ZWQgZm9ybWF0IGlzIHByZXNlbnQgYXMgYSBrZXkKPiArbWFwcGlu ZyB0byBDPDE+LiBGb3IgZXhhbXBsZToKPiArCj4gKyAgICB7Cj4gKyAgICAgICAgZGVmYXVsdCA9 PiAncmF3JywKPiArICAgICAgICB2YWxpZCA9PiB7Cj4gKyAgICAgICAgICAgICdxY293MiA9PiAx LAo+ICsgICAgICAgICAgICAncmF3JyA9PiAxLAo+ICsgICAgICAgIH0sCj4gKyAgICB9Cj4gKwo+ ICs9Y3V0Cj4gKwo+ICtzdWIgZ2V0X2Zvcm1hdHMgewo+ICsgICAgbXkgKCRjbGFzcywgJHNjZmcs ICRzdG9yZWlkKSA9IEBfOwo+ICsKPiArICAgIG15ICR0eXBlID0gJHNjZmctPnt0eXBlfTsKPiAr ICAgIG15ICRwbHVnaW5fZGF0YSA9ICRkZWZhdWx0RGF0YS0+e3BsdWdpbmRhdGF9LT57JHR5cGV9 Owo+ICsKPiArICAgIHJldHVybiB7IGRlZmF1bHQgPT4gJ3JhdycsIHZhbGlkID0+IHsgcmF3ID0+ IDEgfSB9IGlmICFkZWZpbmVkKCRwbHVnaW5fZGF0YS0+e2Zvcm1hdH0pOwo+ICsKPiArICAgIHJl dHVybiB7Cj4gKyAgICAgICAgZGVmYXVsdCA9PiAkc2NmZy0+e2Zvcm1hdH0gfHwgJHBsdWdpbl9k YXRhLT57Zm9ybWF0fS0+WzFdLAo+ICsgICAgICAgICMgY29weSByYXRoZXIgdGhhbiBwYXNzaW5n IGRpcmVjdCByZWZlcmVuY2UKPiArICAgICAgICB2YWxpZCA9PiB7ICRwbHVnaW5fZGF0YS0+e2Zv cm1hdH0tPlswXS0+JSogfSwKPiArICAgIH07Cj4gK30KPiArCj4gICMgY2FsbGVkIGR1cmluZyBh ZGRpdGlvbiBvZiBzdG9yYWdlIChiZWZvcmUgdGhlIG5ldyBzdG9yYWdlIGNvbmZpZyBnb3Qgd3Jp dHRlbikKPiAgIyBkaWUgdG8gYWJvcnQgYWRkaXRpb24gaWYgdGhlcmUgYXJlIChncmF2ZSkgcHJv YmxlbXMKPiAgIyBOT1RFOiBydW5zIGluIGEgc3RvcmFnZSBjb25maWcgKmxvY2tlZCogY29udGV4 dAo+IEBAIC0xNTI2LDggKzE1NDcsOCBAQCBzdWIgbGlzdF9pbWFnZXMgewo+ICAKPiAgICAgIG15 ICRpbWFnZWRpciA9ICRjbGFzcy0+Z2V0X3N1YmRpcigkc2NmZywgJ2ltYWdlcycpOwo+ICAKPiAt ICAgIG15ICgkZGVmRm10LCAkdmFpZEZtdHMpID0gZGVmYXVsdF9mb3JtYXQoJHNjZmcpOwo+IC0g ICAgbXkgJGZtdHMgPSBqb2luKCd8JywgQCR2YWlkRm10cyk7Cj4gKyAgICBteSAkZm9ybWF0X2lu Zm8gPSAkY2xhc3MtPmdldF9mb3JtYXRzKCRzY2ZnLCAkc3RvcmVpZCk7Cj4gKyAgICBteSAkZm10 cyA9IGpvaW4oJ3wnLCBzb3J0IGtleXMgJGZvcm1hdF9pbmZvLT57dmFsaWR9LT4lKik7Cj4gIAo+ ICAgICAgbXkgJHJlcyA9IFtdOwo+ICAKPiAtLSAKPiAyLjQ3LjIKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpwdmUtZGV2ZWwgbWFpbGluZyBsaXN0CnB2 ZS1kZXZlbEBsaXN0cy5wcm94bW94LmNvbQpodHRwczovL2xpc3RzLnByb3htb3guY29tL2NnaS1i aW4vbWFpbG1hbi9saXN0aW5mby9wdmUtZGV2ZWwK