From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 44B4791088 for ; Fri, 26 Jan 2024 13:31:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1EE1035535 for ; Fri, 26 Jan 2024 13:31:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 26 Jan 2024 13:31:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 561BD492C3 for ; Fri, 26 Jan 2024 13:31:24 +0100 (CET) Date: Fri, 26 Jan 2024 13:31:23 +0100 From: Wolfgang Bumiller To: Folke Gleumes Cc: Proxmox VE development discussion Message-ID: References: <20240122101206.226150-1-f.gleumes@proxmox.com> <1706003149.vhzmc5u0zf.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH container] fix #5194: delete environment variables set by pve X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2024 12:31:55 -0000 On Fri, Jan 26, 2024 at 12:39:17PM +0100, Folke Gleumes wrote: > On Tue, 2024-01-23 at 10:51 +0100, Fabian Grünbichler wrote: > > On January 22, 2024 11:12 am, Folke Gleumes wrote: > > > proxmox-perl-rs set's SSL_CERT_{DIR,FILE}, which can break ssl in > > > containers if their certificate store can't be found in the same > > > spot. > > > This patch explicitly unsets those variables before starting the > > > container. > > > > after a short talk with Wolfgang - this patch is probably an okay > > stop-gap to fix the particular regression. > If I understood things correctly, setting the env variables won't be > necessary with the next Debian major release, so I'll add a notice to > remove the workaround with pve 9 [0]. Just note that while it won't be necessary for us to set them *early*, they will still be set by the `openssl-probe` if any rust code calling into something related to that from the `openssl` crate is called. This is already kind of annoying, but nonetheless, at host/container boundaries we should always deal with the environment anyway. > > > > but it might be nice to switch to `--clear-env` for lxc-attach with > > corresponding options for pct to either preserve the whole env, or > > particular variables? might be 9.0 material since it is a semantic > > change that possibly breaks scripted use cases that rely on env > > variables to pass along things from host to whatever they run inside > > the > > container.. we could introduce the options now though and also have a > > `--keep-env` that is the default for 8.x, and flip it to default to > > `--clear-env` with 9.0. > Seems like a good idea. I also noticed that the lxc-attach man page > currently states "[keep-env] is the current default behaviour (as of > version 0.9), but is is likely to change in the future". By defining > it explicitly, we would be free to decide when to introduce the change. Exactly.