From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id DFCAB1FF164
for <inbox@lore.proxmox.com>; Fri, 28 Feb 2025 13:53:04 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id CB631D9DB;
Fri, 28 Feb 2025 13:53:01 +0100 (CET)
Date: Fri, 28 Feb 2025 13:52:57 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <dkpw5qjddulb3iahr77ge7uf3s47rvncn5v5olidk4q2j5tucl@ty73te3dsrcm>
Mail-Followup-To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250214133951.344500-1-g.goller@proxmox.com>
<20250214133951.344500-6-g.goller@proxmox.com>
<554d7ae7-ea2e-4e07-8298-5931bf77caef@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <554d7ae7-ea2e-4e07-8298-5931bf77caef@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.029 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [cluster.pm]
Subject: Re: [pve-devel] [PATCH pve-cluster 05/11] cluster: add sdn fabrics
config files
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 28.02.2025 13:19, Thomas Lamprecht wrote:
>Am 14.02.25 um 14:39 schrieb Gabriel Goller:
>> Add the sdn fabrics config files. These are split into two, as we
>> currently support two fabric types: ospf and openfabric. They hold the
>> whole configuration for the respective protocols. They are read and
>> written by pve-network.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> src/PVE/Cluster.pm | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm
>> index e0e3ee995085..a325b67905b8 100644
>> --- a/src/PVE/Cluster.pm
>> +++ b/src/PVE/Cluster.pm
>> @@ -81,6 +81,8 @@ my $observed = {
>> 'sdn/pve-ipam-state.json' => 1,
>> 'sdn/mac-cache.json' => 1,
>> 'sdn/dns.cfg' => 1,
>> + 'sdn/fabrics/openfabric.cfg' => 1,
>> + 'sdn/fabrics/ospf.cfg' => 1,
>
>You also need to add these to the pmxcfs' memdb_change_array in status.c
>to actually do something.
Ah, didn't see that one, thanks!
>FWIW, could also use the singular for fabric here, but there isn't that
>clearly consistent existing style, so the biggest benefit would be shorter
>paths, not that a single character is much worth here, just noting as it
>stuck out.
We seem to use plural for all the sdn config files (subnets.cfg,
controllers.cfg, vnets.cfg, etc.).
But no hard feelings here.
>> 'sdn/.running-config' => 1,
>> 'virtual-guest/cpu-models.conf' => 1,
>> 'virtual-guest/profiles.cfg' => 1,
Thanks for reviewing this!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel