From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id B4D631FF168
	for <inbox@lore.proxmox.com>; Tue,  7 Jan 2025 15:14:58 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C672E5920;
	Tue,  7 Jan 2025 15:14:45 +0100 (CET)
Date: Tue, 7 Jan 2025 15:14:42 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Message-ID: <dilh56i2iph3jnwxhekpy23r4buhzpninuxi26lxfo3rpra545@otdmwryeyuz3>
References: <20241210151130.321984-1-g.goller@proxmox.com>
 <20241210151130.321984-4-g.goller@proxmox.com>
 <s8osequb62h.fsf@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <s8osequb62h.fsf@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.033 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH container v2 3/3] api: return all addresses
 of an interface
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 11.12.2024 15:57, Maximiliano Sandoval wrote:
>
>Gabriel Goller <g.goller@proxmox.com> writes:
>
>> +		"ip-addresses" => {
>> +		    type => 'array',
>> +		    description => 'All the Addresses of the interface',
>> +		    optional => 0,
>> +		    items => {
>> +			type => 'object',
>
>I feel 'The addresses of the interface' sounds a bit better. But no
>strong opinion.
>
>Is it intentional that `Addresses` is capitalized? If this is Header
>Capitalization then the word "interface" should be capitalized too.

I agree, thanks for the heads up!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel