From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3CDCE61FB3 for ; Fri, 23 Oct 2020 13:28:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FB1128199 for ; Fri, 23 Oct 2020 13:28:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1433928189 for ; Fri, 23 Oct 2020 13:28:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D172C45EF5 for ; Fri, 23 Oct 2020 13:28:33 +0200 (CEST) To: PVE development discussion , Dominik Csapak References: <20200422072623.364-1-d.csapak@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Fri, 23 Oct 2020 13:28:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20200422072623.364-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.122 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH widget-toolkit] improve multiselect behaviour for checkboxmodel X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2020 11:28:35 -0000 On 22.04.20 09:26, Dominik Csapak wrote: > when using the mode 'MULTI' for the checkbox selection model, > clicking a row would deselect all others, only clicking exactly on the > checkbox would select multiple rows > > this override makes the whole cell of the checkbox behave like the > checkbox. This minimizes misclicks from the user. > > Signed-off-by: Dominik Csapak > --- > btw. the extjs docs lie, the default is not > 'x-grid-row-checker' but '.x-grid-row-checker' > so when setting a different class the '.' is not optional > 20 minutes of my life i will not get back... > > Toolkit.js | 7 +++++++ > 1 file changed, 7 insertions(+) > > better late than never, I guess :) applied, thanks! FYI: had to use apply it with 3-way merge, as there where some context changes (possibly the ones from eslint fixes). > Applying: improve multiselect behaviour for checkboxmodel > Using index info to reconstruct a base tree... > A Toolkit.js > Falling back to patching base and 3-way merge... > Auto-merging src/Toolkit.js