From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8CAB31FF17E for ; Thu, 11 Dec 2025 14:30:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D2BF162BB; Thu, 11 Dec 2025 14:30:58 +0100 (CET) Message-ID: Date: Thu, 11 Dec 2025 14:30:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Dominik Csapak References: <20251118144902.3001963-1-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20251118144902.3001963-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765459822158 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 18.11.25 um 3:48 PM schrieb Dominik Csapak: > the resource store has a field 'diskuse' which it calculates on update. > Use that instead of calculating the value ourselves everytime. > > For change detection, we only need a resolution of 0.01 (since we want > to use the percentage as integer) so check that the difference of old and new > is bigger than 0.9% . > > Signed-off-by: Dominik Csapak > --- > www/manager6/tree/ResourceTree.js | 27 ++++++++++++++++++--------- > 1 file changed, 18 insertions(+), 9 deletions(-) > > diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js > index bb016f8c..4c4e2908 100644 > --- a/www/manager6/tree/ResourceTree.js > +++ b/www/manager6/tree/ResourceTree.js > @@ -57,7 +57,7 @@ Ext.define('PVE.tree.ResourceTree', { > let text = info.text; > let status = ''; > if (info.type === 'storage') { > - let usage = info.disk / info.maxdisk; > + let usage = info.diskuse; > if (usage >= 0.0 && usage <= 1.0) { > let barHeight = (usage * 100).toFixed(0); > let remainingHeight = (100 - barHeight).toFixed(0); > @@ -186,7 +186,7 @@ Ext.define('PVE.tree.ResourceTree', { > qtips.push(Ext.String.format(gettext('HA State: {0}'), info.hastate)); > } > if (info.type === 'storage') { > - let usage = info.disk / info.maxdisk; > + let usage = info.diskuse; > if (usage >= 0.0 && usage <= 1.0) { > qtips.push(Ext.String.format(gettext('Usage: {0}%'), (usage * 100).toFixed(2))); > } > @@ -310,8 +310,6 @@ Ext.define('PVE.tree.ResourceTree', { > let stateid = 'rid'; > > const changedFields = [ > - 'disk', > - 'maxdisk', > 'vmid', > 'name', > 'type', > @@ -409,14 +407,25 @@ Ext.define('PVE.tree.ResourceTree', { > } > } > > - // tree item has been updated > - for (const field of changedFields) { > - if (item.data[field] !== olditem.data[field]) { > + let diskuse = item.data.diskuse; > + let oldDiskuse = olditem.data.diskuse; > + > + if (diskuse !== undefined || oldDiskuse !== undefined) { > + if (Math.abs(diskuse - oldDiskuse) > 0.009) { Is there a specific reason for using > 0.009? You write "resolution of 0.01", so intuitively, I'd expect >= 0.01 or, maybe if rounding matters, >= 0.0095. If we get a lot of incremental small changes after each other, we might not detect a change even though it could've changed a lot overall? > changed = true; > - break; > } > } > - // FIXME: also test filterfn()? > + > + if (!changed) { > + // tree item has been updated > + for (const field of changedFields) { > + if (item.data[field] !== olditem.data[field]) { > + changed = true; > + break; > + } > + } > + // FIXME: also test filterfn()? > + } > } > > if (changed) { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel