From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2EF6294D60 for ; Fri, 23 Feb 2024 12:51:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F01A17BA9 for ; Fri, 23 Feb 2024 12:51:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Feb 2024 12:51:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3FAD044F16 for ; Fri, 23 Feb 2024 12:51:35 +0100 (CET) Message-ID: Date: Fri, 23 Feb 2024 12:51:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Hannes Laimer References: <20240223114551.15392-1-h.laimer@proxmox.com> From: Aaron Lauterer In-Reply-To: <20240223114551.15392-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-manager] ui: storage: add is_mountpoint checkmark to directory storage edit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2024 11:51:36 -0000 Overall good idea :) On 2/23/24 12:45, Hannes Laimer wrote: > Signed-off-by: Hannes Laimer > --- > > came up in enterprise support, and I don't think there is a reason to > not have it in the UI, while having it in the API > > www/manager6/storage/DirEdit.js | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js > index 3e2025fc..52e7134b 100644 > --- a/www/manager6/storage/DirEdit.js > +++ b/www/manager6/storage/DirEdit.js > @@ -37,6 +37,18 @@ Ext.define('PVE.storage.DirInputPanel', { > }, > ]; > > + me.advancedColumn2 = [ > + { > + xtype: 'proxmoxcheckbox', > + name: 'is_mountpoint', > + uncheckedValue: 0, > + fieldLabel: gettext('Mountpoint'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Enable if something is mounted to this directory externally, storage is considered offline as long as nothing is mounted.'), Maybe phrase the tooltip like this? Enable if something is mounted at this path. Storage is considered offline as long as nothing is mounted. As there are also use-cases where something local is mounted outside of the PVE tooling where the is_mountpoint option is useful. > + }, > + }, > + ]; > me.callParent(); > }, > });