From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 50B1D1FF15C for ; Fri, 17 Oct 2025 09:40:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BBEE320EC5; Fri, 17 Oct 2025 09:40:37 +0200 (CEST) Message-ID: Date: Fri, 17 Oct 2025 09:40:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Shan Shaji References: <20251001095231.4458-1-s.shaji@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20251001095231.4458-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760686830981 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox_dart_api_client] fix: ios: add type check to catch `NSErrorClientException` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" wouldn't it be easier and more robust if we simply reverse the two catch blocks? e.g try { } on... { ... } on NSErrorClientException catch (e) { ... } on http.ClientException catch (e) { ... } ? On 10/1/25 11:52 AM, Shan Shaji wrote: > The `NSErrorClientException` catch clause was not being executed because > it's a subtype of `ClientException`. This resulted in showing the > actual error from the package instead of our custom error message when > the SSL/TLS handshake failed. Fixed the issue by adding a type check > inside the `ClientException` catch clause. > > Signed-off-by: Shan Shaji > --- > lib/src/authenticate.dart | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/src/authenticate.dart b/lib/src/authenticate.dart > index 04f363f..aaae50b 100644 > --- a/lib/src/authenticate.dart > +++ b/lib/src/authenticate.dart > @@ -61,12 +61,12 @@ Future authenticate( > if (e.message.contains('net::ERR_CERT_AUTHORITY_INVALID')) { > throw HandshakeException(e.message); > } > - rethrow; > - } on NSErrorClientException catch (e) { > + > // Treat untrusted server certificate (-1202) as a handshake failure. > - if (e.error.code == -1202) { > + if (e is NSErrorClientException && e.error.code == -1202) { > throw HandshakeException(e.message); > } > + > rethrow; > } > } > @@ -91,12 +91,12 @@ Future> accessDomains( > if (e.message.contains('net::ERR_CERT_AUTHORITY_INVALID')) { > throw HandshakeException(e.message); > } > - rethrow; > - } on NSErrorClientException catch (e) { > + > // Treat untrusted server certificate (-1202) as a handshake failure. > - if (e.error.code == -1202) { > + if (e is NSErrorClientException && e.error.code == -1202) { > throw HandshakeException(e.message); > } > + > rethrow; > } > } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel