From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 70ECF1FF164 for ; Fri, 4 Jul 2025 15:31:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E35A038C35; Fri, 4 Jul 2025 15:31:50 +0200 (CEST) Date: Fri, 4 Jul 2025 15:31:48 +0200 From: Wolfgang Bumiller To: Stefan Hanreich Message-ID: References: <20250702145101.894299-1-g.goller@proxmox.com> <20250702145101.894299-32-g.goller@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.080 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-perl-rs v4 3/5] pve-rs: sdn: fabrics: add frr config generation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Fri, Jul 04, 2025 at 03:23:14PM +0200, Stefan Hanreich wrote: > On 7/4/25 15:14, Wolfgang Bumiller wrote: > > [snip] > > >> + > >> + /// Class method: Return all FRR daemons that need to be enabled for this fabric configuration > >> + /// instance. > > > > Method* > > > > Daemons? Or would "services" make more sense (and a `.service` suffix?) > > It's a bit weird with FRR, there's only frr.service and it starts > daemons based on the config in /etc/frr/daemons - hence why I think > daemons is more fitting. Ah okay, didn't realize this was about a config file. (Maybe link the docs or mention the file in the doc comment?) > > [snip] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel