From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E9422948E9 for <pve-devel@lists.proxmox.com>; Fri, 13 Jan 2023 13:53:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C4F755842 for <pve-devel@lists.proxmox.com>; Fri, 13 Jan 2023 13:53:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 13 Jan 2023 13:53:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA5B74502E for <pve-devel@lists.proxmox.com>; Fri, 13 Jan 2023 13:53:11 +0100 (CET) Message-ID: <deda5a6f-17e1-e697-2d67-9ca5a63727e9@proxmox.com> Date: Fri, 13 Jan 2023 13:53:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com> References: <20221220103037.890813-1-s.sterz@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20221220103037.890813-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: [pve-devel] applied: [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 13 Jan 2023 12:53:13 -0000 Am 20/12/2022 um 11:30 schrieb Stefan Sterz: > when a vm is configured to use a physical cd rom drive but there is no > such drive a cryptic "uninitialized value" error is thrown. this is > due to `$path` being undefined in `sub print_drive_commandline_full`. > warn that no cd rom drive is available instead. > > note that the error was cosmetic as the vm would start just fine. > > forum thread: https://forum.proxmox.com/threads/119592/ > > Signed-off-by: Stefan Sterz <s.sterz@proxmox.com> > --- > changes from v3 (thanks @ Thomas Lamprecht): > > * use `log_warn` instead of `warn` > * dont return results of assignments > > changes from v2 (thanks @ Fiona Ebner): > > * added newline to message > * cache the fact that no drive is available so we warn only once > * adjusted error message again > > changes from v1: > > * make the error message more concise. > * use shorter forum link for better formatting in commit message > (thanks @ Fiona Ebner). > > > PVE/QemuServer.pm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > applied both patches, thanks!