From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id DCE311FF0E7
	for <inbox@lore.proxmox.com>; Fri, 10 Jul 2026 09:03:53 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id AE4BD214AC;
	Fri, 10 Jul 2026 09:03:53 +0200 (CEST)
Message-ID: <ded34f74-da5a-4971-b6af-58fdc740ee12@proxmox.com>
Date: Fri, 10 Jul 2026 09:03:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH manager 3/4] fix #6211: ui: vm: options:
To: Elias Huhsovitz <e.huhsovitz@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260708130453.166084-1-e.huhsovitz@proxmox.com>
 <20260708130453.166084-4-e.huhsovitz@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20260708130453.166084-4-e.huhsovitz@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783667018952
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.067 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: QKRM25MFWFMMZPW6N7VRSJTTDBJCJGJL
X-Message-ID-Hash: QKRM25MFWFMMZPW6N7VRSJTTDBJCJGJL
X-MailFrom: d.csapak@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

the commit subject seems to be cut off? (stray newline?)

aside from that:

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 7/8/26 3:05 PM, Elias Huhsovitz wrote:
> The help buttons in the AMD SEV and Intel TDX dialos were pointing to
> the general
> memory documentation.
> Update the links to use the correct documentation anchors
> 
> Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
> ---
>   www/manager6/qemu/SevEdit.js | 2 +-
>   www/manager6/qemu/TdxEdit.js | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/qemu/SevEdit.js b/www/manager6/qemu/SevEdit.js
> index 44db34bd..c308b3ab 100644
> --- a/www/manager6/qemu/SevEdit.js
> +++ b/www/manager6/qemu/SevEdit.js
> @@ -2,7 +2,7 @@ Ext.define('PVE.qemu.SevInputPanel', {
>       extend: 'Proxmox.panel.InputPanel',
>       xtype: 'pveSevInputPanel',
>   
> -    onlineHelp: 'qm_memory', // TODO: change to 'qm_memory_encryption' one available
> +    onlineHelp: 'qm_memory_encryption_sev',
>   
>       viewModel: {
>           data: {
> diff --git a/www/manager6/qemu/TdxEdit.js b/www/manager6/qemu/TdxEdit.js
> index c1f990a9..38948a6c 100644
> --- a/www/manager6/qemu/TdxEdit.js
> +++ b/www/manager6/qemu/TdxEdit.js
> @@ -2,7 +2,7 @@ Ext.define('PVE.qemu.TdxInputPanel', {
>       extend: 'Proxmox.panel.InputPanel',
>       xtype: 'pveTdxInputPanel',
>   
> -    onlineHelp: 'qm_memory', // TODO: change to 'qm_memory_encryption' one available
> +    onlineHelp: 'qm_memory_encryption_tdx',
>   
>       viewModel: {
>           data: {