From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 477219392F
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 12:01:07 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 439BBBFB
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 12:01:07 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 12:01:05 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6CDD043CF6
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 12:01:05 +0200 (CEST)
Message-ID: <de9d877c-5ce6-4750-1769-9072ca54f31b@proxmox.com>
Date: Mon, 19 Sep 2022 12:01:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101
Thunderbird/105.0
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
References: <20220919091621.29538-1-f.ebner@proxmox.com>
<20220919091621.29538-2-f.ebner@proxmox.com>
Content-Language: en-GB
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220919091621.29538-2-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 1.812 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -3.657 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH/RFC manager 2/2] ui: qemu: CD edit: make
label for storage more descriptive
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 19 Sep 2022 10:01:07 -0000
On 19/09/2022 11:16, Fiona Ebner wrote:
> Namely, use "ISO storage" instead of "Storage". Relevant when inside
> the wizard, to avoid any confusion, but doesn't really feel wrong in
> the normal edit window either.
>
> Suggested in the community forum:
> https://forum.proxmox.com/threads/75219/post-498758
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> I feel like the first patch might already be enough, but this would
> drive home the point.
Something like that could be OK in general, but a nit could be that the
selector isn't really limited to images in ISO format, so this could actually
add more confusion than it might resolve, IMO doing just the label is more than
enough, this UX confusion didn't came up _that_ often to classify it as issue
for a significant amount of users (still good to improve it for those that are
affected, as it's mostly first time users, which may be overloaded with a new
project)
>
> www/manager6/qemu/CDEdit.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
> index f409fa53..33c12d43 100644
> --- a/www/manager6/qemu/CDEdit.js
> +++ b/www/manager6/qemu/CDEdit.js
> @@ -118,7 +118,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
> me.cdstoragesel = Ext.create('PVE.form.StorageSelector', {
> name: 'cdstorage',
> nodename: me.nodename,
> - fieldLabel: gettext('Storage'),
> + fieldLabel: gettext('ISO storage'),
> labelAlign: 'right',
> storageContent: 'iso',
> allowBlank: false,