From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1ADCF1FF380 for ; Fri, 19 Apr 2024 12:32:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 229A063A7; Fri, 19 Apr 2024 12:32:07 +0200 (CEST) Message-ID: Date: Fri, 19 Apr 2024 12:31:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Lukas Wagner References: <20240415082614.2515677-1-l.wagner@proxmox.com> <20240415082614.2515677-5-l.wagner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240415082614.2515677-5-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v5 04/16] ui: dc: backup: allow to set custom job id in advanced settings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 15.04.24 um 10:26 schrieb Lukas Wagner: > This might be useful if somebody wants to match on the new > 'backup-job' field in a notification match rule. > > Signed-off-by: Lukas Wagner > --- > www/manager6/Utils.js | 4 ++++ > www/manager6/dc/Backup.js | 11 +++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index 287d651a..d4b5f3e6 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -1952,6 +1952,10 @@ Ext.define('PVE.Utils', { > singleton: true, > constructor: function() { > var me = this; > + > + // Same regex as 'pve-configid > + me.CONFIGID_RE = /^[A-Za-z][A-Za-z0-9_-]+$/; This already exists (with nice verification errors), by using vtype: 'ConfigId' for the field. It's defined in widget-toolkit, Toolkit.js > + > Ext.apply(me, me.utilities); > > Proxmox.Utils.override_task_descriptions({ > diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js > index 4beb84c0..5b6f6688 100644 > --- a/www/manager6/dc/Backup.js > +++ b/www/manager6/dc/Backup.js > @@ -397,6 +397,17 @@ Ext.define('PVE.dc.BackupEdit', { > }, > ], > advancedColumn1: [ > + { > + xtype: 'pmxDisplayEditField', > + fieldLabel: gettext('Job ID'), > + emptyText: gettext('Autogenerate'), > + name: 'id', > + allowBlank: true, > + regex: PVE.Utils.CONFIGID_RE, > + cbind: { > + editable: '{isCreate}', > + }, > + }, > { > xtype: 'proxmoxcheckbox', > fieldLabel: gettext('Repeat missed'), _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel