From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 73018624D0 for ; Mon, 23 Nov 2020 15:58:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7123E2A9DD for ; Mon, 23 Nov 2020 15:58:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 64DBA2A9CE for ; Mon, 23 Nov 2020 15:58:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 34D0943F19 for ; Mon, 23 Nov 2020 15:58:08 +0100 (CET) To: Proxmox VE development discussion , Fabian Ebner References: <20201123123310.13898-1-f.ebner@proxmox.com> <20201123123310.13898-2-f.ebner@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Mon, 23 Nov 2020 15:58:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201123123310.13898-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.084 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm] Subject: [pve-devel] applied: [PATCH storage 2/3] convert maxfiles to prune_backups when reading the storage configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2020 14:58:09 -0000 On 23.11.20 13:33, Fabian Ebner wrote: > If there are already prune options configured, simply delete the maxfiles > setting. Having set both is invalid from vzdump's perspective anyways, and any > backup job on such a storage failed, meaning a user would've noticed. > > If there are no prune options, translate the maxfiles value to keep-last, > except for maxfiles being zero (=unlimited), in which case we use keep-all. > > If both are not set, don't set anything, so: > 1. Storages don't suddenly have retention options set. > 2. People relying on vzdump defaults can still use those. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage.pm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > applied, thanks!