From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E4DEA20EC89 for ; Tue, 23 Apr 2024 09:24:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B9F851C308; Tue, 23 Apr 2024 09:24:09 +0200 (CEST) Message-ID: Date: Tue, 23 Apr 2024 09:24:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Markus Frank References: <20240422121617.1131803-1-m.frank@proxmox.com> <20240422121617.1131803-2-m.frank@proxmox.com> Content-Language: en-GB, de-AT From: Thomas Lamprecht Autocrypt: addr=t.lamprecht@proxmox.com; keydata= xsFNBFsLjcYBEACsaQP6uTtw/xHTUCKF4VD4/Wfg7gGn47+OfCKJQAD+Oyb3HSBkjclopC5J uXsB1vVOfqVYE6PO8FlD2L5nxgT3SWkc6Ka634G/yGDU3ZC3C/7NcDVKhSBI5E0ww4Qj8s9w OQRloemb5LOBkJNEUshkWRTHHOmk6QqFB/qBPW2COpAx6oyxVUvBCgm/1S0dAZ9gfkvpqFSD 90B5j3bL6i9FIv3YGUCgz6Ue3f7u+HsEAew6TMtlt90XV3vT4M2IOuECG/pXwTy7NtmHaBQ7 UJBcwSOpDEweNob50+9B4KbnVn1ydx+K6UnEcGDvUWBkREccvuExvupYYYQ5dIhRFf3fkS4+ wMlyAFh8PQUgauod+vqs45FJaSgTqIALSBsEHKEs6IoTXtnnpbhu3p6XBin4hunwoBFiyYt6 YHLAM1yLfCyX510DFzX/Ze2hLqatqzY5Wa7NIXqYYelz7tXiuCLHP84+sV6JtEkeSUCuOiUY virj6nT/nJK8m0BzdR6FgGtNxp7RVXFRz/+mwijJVLpFsyG1i0Hmv2zTn3h2nyGK/I6yhFNt dX69y5hbo6LAsRjLUvZeHXpTU4TrpN/WiCjJblbj5um5eEr4yhcwhVmG102puTtuCECsDucZ jpKpUqzXlpLbzG/dp9dXFH3MivvfuaHrg3MtjXY1i+/Oxyp5iwARAQABzTNUaG9tYXMgTGFt cHJlY2h0IChBdXRoLTQpIDx0LmxhbXByZWNodEBwcm94bW94LmNvbT7CwY4EEwEIADgWIQQO R4qbEl/pah9K6VrTZCM6gDZWBgUCWwuNxgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDTZCM6gDZWBm/jD/4+6JB2s67eaqoP6x9VGaXNGJPCscwzLuxDTCG90G9FYu29VcXtubH/ bPwsyBbNUQpqTm/s4XboU2qpS5ykCuTjqavrcP33tdkYfGcItj2xMipJ1i3TWvpikQVsX42R G64wovLs/dvpTYphRZkg5DwhgTmy3mRkmofFCTa+//MOcNOORltemp984tWjpR3bUJETNWpF sKGZHa3N4kCNxb7A+VMsJZ/1gN3jbQbQG7GkJtnHlWkw9rKCYqBtWrnrHa4UAvSa9M/XCIAB FThFGqZI1ojdVlv5gd6b/nWxfOPrLlSxbUo5FZ1i/ycj7/24nznW1V4ykG9iUld4uYUY86bB UGSjew1KYp9FmvKiwEoB+zxNnuEQfS7/Bj1X9nxizgweiHIyFsRqgogTvLh403QMSGNSoArk tqkorf1U+VhEncIn4H3KksJF0njZKfilrieOO7Vuot1xKr9QnYrZzJ7m7ZxJ/JfKGaRHXkE1 feMmrvZD1AtdUATZkoeQtTOpMu4r6IQRfSdwm/CkppZXfDe50DJxAMDWwfK2rr2bVkNg/yZI tKLBS0YgRTIynkvv0h8d9dIjiicw3RMeYXyqOnSWVva2r+tl+JBaenr8YTQw0zARrhC0mttu cIZGnVEvQuDwib57QLqMjQaC1gazKHvhA15H5MNxUhwm229UmdH3KM7BTQRbC43GARAAyTkR D6KRJ9Xa2fVMh+6f186q0M3ni+5tsaVhUiykxjsPgkuWXWW9MbLpYXkzX6h/RIEKlo2BGA95 QwG5+Ya2Bo3g7FGJHAkXY6loq7DgMp5/TVQ8phsSv3WxPTJLCBq6vNBamp5hda4cfXFUymsy HsJy4dtgkrPQ/bnsdFDCRUuhJHopnAzKHN8APXpKU6xV5e3GE4LwFsDhNHfH/m9+2yO/trcD txSFpyftbK2gaMERHgA8SKkzRhiwRTt9w5idOfpJVkYRsgvuSGZ0pcD4kLCOIFrer5xXudk6 NgJc36XkFRMnwqrL/bB4k6Pi2u5leyqcXSLyBgeHsZJxg6Lcr2LZ35+8RQGPOw9C0ItmRjtY ZpGKPlSxjxA1WHT2YlF9CEt3nx7c4C3thHHtqBra6BGPyW8rvtq4zRqZRLPmZ0kt/kiMPhTM 8wZAlObbATVrUMcZ/uNjRv2vU9O5aTAD9E5r1B0dlqKgxyoImUWB0JgpILADaT3VybDd3C8X s6Jt8MytUP+1cEWt9VKo4vY4Jh5vwrJUDLJvzpN+TsYCZPNVj18+jf9uGRaoK6W++DdMAr5l gQiwsNgf9372dbMI7pt2gnT5/YdG+ZHnIIlXC6OUonA1Ro/Itg90Q7iQySnKKkqqnWVc+qO9 GJbzcGykxD6EQtCSlurt3/5IXTA7t6sAEQEAAcLBdgQYAQgAIBYhBA5HipsSX+lqH0rpWtNk IzqANlYGBQJbC43GAhsMAAoJENNkIzqANlYGD1sP/ikKgHgcspEKqDED9gQrTBvipH85si0j /Jwu/tBtnYjLgKLh2cjv1JkgYYjb3DyZa1pLsIv6rGnPX9bH9IN03nqirC/Q1Y1lnbNTynPk IflgvsJjoTNZjgu1wUdQlBgL/JhUp1sIYID11jZphgzfDgp/E6ve/8xE2HMAnf4zAfJaKgD0 F+fL1DlcdYUditAiYEuN40Ns/abKs8I1MYx7Yglu3RzJfBzV4t86DAR+OvuF9v188WrFwXCS RSf4DmJ8tntyNej+DVGUnmKHupLQJO7uqCKB/1HLlMKc5G3GLoGqJliHjUHUAXNzinlpE2Vj C78pxpwxRNg2ilE3AhPoAXrY5qED5PLE9sLnmQ9AzRcMMJUXjTNEDxEYbF55SdGBHHOAcZtA kEQKub86e+GHA+Z8oXQSGeSGOkqHi7zfgW1UexddTvaRwE6AyZ6FxTApm8wq8NT2cryWPWTF BDSGB3ujWHMM8ERRYJPcBSjTvt0GcEqnd+OSGgxTkGOdufn51oz82zfpVo1t+J/FNz6MRMcg 8nEC+uKvgzH1nujxJ5pRCBOquFZaGn/p71Yr0oVitkttLKblFsqwa+10Lt6HBxm+2+VLp4Ja 0WZNncZciz3V3cuArpan/ZhhyiWYV5FD0pOXPCJIx7WS9PTtxiv0AOS4ScWEUmBxyhFeOpYa DrEx In-Reply-To: <20240422121617.1131803-2-m.frank@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v7 2/3] config: QEMU AMD SEV enable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 22/04/2024 um 14:16 schrieb Markus Frank: > This patch is for enabling AMD SEV (Secure Encrypted > Virtualization) support in QEMU try to keep a somewhat unified line length over the whole commit message, most editors support re-flowing (parts of the) text to e.g. the for commit messages commonly used 70 or 72 text width. > > VM-Config-Examples: > amd_sev: type=std,nodbg=1,noks=1 > amd_sev: es,nodbg=1,kernel-hashes=1 > > Node-Config-Example (gets generated automatically): > amd_sev: cbitpos=47,reduced-phys-bios=1 > > kernel-hashes, reduced-phys-bios & cbitpos correspond to the varibles typo: variables > with the same name in qemu. > > kernel-hashes=1 adds kernel-hashes to enable measured linux kernel > launch since it is per default off for backward compatibility. > > reduced-phys-bios and cbitpos are system specific and are read out by > the amd-sev-support.service on boot and saved to the /run/amd-sev-params > file. This file is parsed and than used by qemu-server to correctly > start a AMD SEV VM. > > type=std stands for standard sev to differentiate it from sev-es (es) > or sev-snp (snp) when support is upstream. > > QEMU's sev-guest policy gets calculated with the parameters nodbg & noks > These parameters correspond to policy-bits 0 & 1. > If type is 'es' than policy-bit 2 gets set to 1 to activate SEV-ES. > Policy bit 3 (nosend) is always set to 1, because migration > features for sev are not upstream yet and are attackable. > > SEV-ES is highly experimental since it could not be tested. > > see coherent doc patch > > Signed-off-by: Markus Frank > --- > v7: > * adjustments for the changes made in the query-machine-params C program > > v6: > * rebase on master > * removed unused $sev_node_fmt object > > v5: > * parse /run/amd-sev-params for hardware parameters > * removed NodeConfig dependency > * only disallow live-migration and snapshots with vmstate > -> allow offline migration and snapshots without vmstate > > v4: > * reduced lines of code > * added text that SEV-ES is experimental > > PVE/API2/Qemu.pm | 10 ++++++ > PVE/QemuMigrate.pm | 4 +++ > PVE/QemuServer.pm | 83 ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 97 insertions(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 2a349c8..2e8d654 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -4512,6 +4512,10 @@ __PACKAGE__->register_method({ > push $local_resources->@*, "clipboard=vnc"; > } > > + if ($res->{running} && $vmconf->{amd_sev}) { a comment might be good here > + push $local_resources->@*, "amd_sev"; > + } > + > # if vm is not running, return target nodes where local storage/mapped devices are available > # for offline migration > if (!$res->{running}) { > @@ -5192,6 +5196,12 @@ __PACKAGE__->register_method({ > die "unable to use snapshot name 'pending' (reserved name)\n" > if lc($snapname) eq 'pending'; > > + my $conf = PVE::QemuConfig->load_config($vmid); > + if ($param->{vmstate} && $conf->{amd_sev}) { > + die "Snapshots that include memory are not supported while memory" > + ." is encrypted by AMD SEV.\n" > + } > + > my $realcmd = sub { > PVE::Cluster::log_msg('info', $authuser, "snapshot VM $vmid: $snapname"); > PVE::QemuConfig->snapshot_create($vmid, $snapname, $param->{vmstate}, > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 8d9b35a..7db18b2 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -260,6 +260,10 @@ sub prepare { > die "VMs with 'clipboard' set to 'vnc' are not live migratable!\n"; > } > > + if ($running && $conf->{'amd_sev'}) { > + die "VMs with AMD SEV are not live migratable!\n"; cannot live-migrate VM when AMD SEV is enabled. > + } > + > my $vollist = PVE::QemuServer::get_vm_volumes($conf); > > my $storages = {}; > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 28e630d..b03f1b4 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -177,6 +177,40 @@ my $agent_fmt = { > }, > }; > > +my $sev_fmt = { > + type => { > + description => "Enable standard SEV with type='std' or enable experimental SEV-ES" > + ." with the 'es' option.", > + type => 'string', > + default_key => 1, > + format_description => "qemu-sev-type", > + enum => ['std', 'es'], > + maxLength => 3, > + }, > + nodbg => { 'no-debug' would be more telling > + description => "Sets policy bit 0 to 1 to disallow debugging of guest", > + type => 'boolean', > + format_description => "qemu-sev-nodbg", do we need a format description for a boolean > + default => 0, > + optional => 1, > + }, > + noks => { 'no-key-sharing' would be also more telling > + description => "Sets policy bit 1 to 1 to disallow key sharing with other guests", > + type => 'boolean', > + format_description => "qemu-sev-noks", do we need a format description for a boolean > + default => 0, > + optional => 1, > + }, > + "kernel-hashes" => { > + description => "Add kernel hashes to guest firmware for measured linux kernel launch", > + type => 'boolean', > + format_description => "qemu-sev-kernel-hashes", > + default => 0, > + optional => 1, > + }, > +}; > +PVE::JSONSchema::register_format('pve-qemu-sev-fmt', $sev_fmt); > + > my $vga_fmt = { > type => { > description => "Select the VGA type.", > @@ -358,6 +392,12 @@ my $confdesc = { > description => "Memory properties.", > format => $PVE::QemuServer::Memory::memory_fmt > }, > + amd_sev => { > + description => "Secure Encrypted Virtualization (SEV) features by AMD CPUs", > + optional => 1, > + format => 'pve-qemu-sev-fmt', > + type => 'string', > + }, > balloon => { > optional => 1, > type => 'integer', > @@ -4091,6 +4131,39 @@ sub config_to_command { > } > } > > + if ($conf->{amd_sev}) { > + if ($conf->{bios} && $conf->{bios} ne 'ovmf') { > + die "For using SEV you need to change your guest bios to ovmf.\n"; > + } > + > + my $amd_sev_conf = parse_property_string($sev_fmt, $conf->{amd_sev}); > + my $sev_hw_params = get_hw_parameters()->{'amd-sev'}; > + > + if (!$sev_hw_params->{'sev-support'}) { > + die "Your CPU does not support AMD SEV!\n"; > + } > + if ($amd_sev_conf->{type} eq 'es' && !$sev_hw_params->{'sev-support-es'}) { > + die "Your CPU does not support AMD SEV-ES!\n"; > + } > + > + my $sev_mem_object = 'sev-guest,id=sev0' > + .',cbitpos='.$sev_hw_params->{cbitpos} > + .',reduced-phys-bits='.$sev_hw_params->{'reduced-phys-bits'}; > + > + my $policy = 0b0; > + $policy += 0b1 if ($amd_sev_conf->{nodbg}); > + $policy += 0b10 if ($amd_sev_conf->{noks}); > + $policy += 0b100 if ($amd_sev_conf->{type} eq 'es'); > + # disable migration with bit 3 nosend to prevent amd-sev-migration-attack > + $policy += 0b1000; > + > + $sev_mem_object .= ',policy='.sprintf("%#x", $policy); > + $sev_mem_object .= ',kernel-hashes=on' if ($amd_sev_conf->{'kernel-hashes'}); > + > + push @$devices, '-object' , $sev_mem_object; > + push @$machineFlags, 'confidential-guest-support=sev0'; > + } > + > push @$cmd, @$devices; > push @$cmd, '-rtc', join(',', @$rtcFlags) if scalar(@$rtcFlags); > push @$cmd, '-machine', join(',', @$machineFlags) if scalar(@$machineFlags); > @@ -4134,6 +4207,16 @@ sub check_rng_source { > } > } > > +sub get_hw_parameters { > + # Get reduced-phys-bits & cbitpos from /run/qemu-server/hw-params.json > + my $filename = '/run/qemu-server/hw-params.json'; I'd not use params, as parameters are normally something one can change in software, (i.e. without buying a different CPU, and FW updates are a grey area ^^) "host-hw-capabilities.json" might be better here > + open my $fh, '<', $filename or die "Could not open '$filename' for reading: $!"; > + my $json_text = do { local $/; <$fh> }; > + close $fh; > + my $hw_params = JSON->new->decode($json_text); > + return $hw_params; > +} > + > sub spice_port { > my ($vmid) = @_; > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel