From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 16420977F for ; Fri, 1 Apr 2022 11:40:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 044CF24D20 for ; Fri, 1 Apr 2022 11:40:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 40C7A24D15 for ; Fri, 1 Apr 2022 11:40:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 12E8C43694 for ; Fri, 1 Apr 2022 11:40:10 +0200 (CEST) Message-ID: Date: Fri, 1 Apr 2022 11:40:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20220401093202.122978-1-m.limbeck@proxmox.com> From: Mira Limbeck In-Reply-To: <20220401093202.122978-1-m.limbeck@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.314 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 proxmox-openid-rs] fix Open ID with Azure as provider X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 09:40:47 -0000 On 4/1/22 11:32, Mira Limbeck wrote: > Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint, > but with the switch to ureq we always send requests with this set. > > Fix by switching to `Content-Length` in the header instead. ureq only > sets `Transfer-Encoding: chunked` when the body length is not known > beforehand, which is the case when using `send`. See > https://docs.rs/ureq/2.4.0/ureq/index.html#content-length-and-transfer-encoding > > See https://forum.proxmox.com/threads/openid-401-with-azure-ad.105892/ > for the issue. > > Signed-off-by: Mira Limbeck > --- > v2: > - added inline comment > - removed the unnecessary `let bytes = ...` line > - changed link in commit message to versioned docs.rs > > probably also fixes https://bugzilla.proxmox.com/show_bug.cgi?id=3916, > but I could only reproduce this exact error message with Azure until > now. > > src/http_client.rs | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/http_client.rs b/src/http_client.rs > index a2bf6ee..1a16ff3 100644 > --- a/src/http_client.rs > +++ b/src/http_client.rs > @@ -75,7 +75,10 @@ pub fn http_client(request: HttpRequest) -> Result { > } > > let response = if let Method::POST = request.method { > - req.send(&*request.body) > + // send_bytes makes sure that Content-Length is set. This is important, because some > + // endpoints don't accept `Transfer-Encoding: chunked`, which would otherwise be set. > + // see https://github.com/algesten/ureq/blob/main/README.md#content-length-and-transfer-encoding > + req.send_bytes(request.body.as_slice()) > } else { > req.call() > } disregard this patch, it contains the wrong link in the inline comment will send a v3