From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 17BCB1FF164 for ; Fri, 17 Jan 2025 14:34:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 86D7CF664; Fri, 17 Jan 2025 14:34:05 +0100 (CET) Message-ID: Date: Fri, 17 Jan 2025 14:33:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20250116115054.124447-1-f.ebner@proxmox.com> <20250116115054.124447-17-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [machine.pm] Subject: Re: [pve-devel] [PATCH qemu-server v2 16/18] machine: rename machine_version() function to machine_version_at_least() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 17.01.25 um 13:39 schrieb Thomas Lamprecht: > Am 16.01.25 um 12:50 schrieb Fiona Ebner: >> diff --git a/PVE/QemuServer/Machine.pm b/PVE/QemuServer/Machine.pm >> index 9b18cf6e..6398e756 100644 >> --- a/PVE/QemuServer/Machine.pm >> +++ b/PVE/QemuServer/Machine.pm >> @@ -136,7 +136,7 @@ sub extract_version { >> return; >> } >> >> -sub machine_version { >> +sub machine_version_at_least { > > maybe use the chance and prefix with is_ to make this even more clear, i.e. > is_version_at_least or to be very verbose: is_version_greater_or_equal (no > hard feelings there though). Okay, but I'd rather not drop the "machine" from the function name. We have a lot of different versions floating around so even though this is already in the machine module, I'd still like to mention it explicitly in the function name to reduce potential for accidental re-use for other kinds of versions. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel